783663 - ReadPixelsIntoImageSurface pulls from bound framebuffer, not the screen

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

ReadPixelsIntoImageSurface is just a wrapper that calls ReadPixels into a gfxImageSurface. While this is fine, it is used in Layers as if it always reads from the screen, which is not the case.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Actually, it looks like this is only the case on OGL Layers.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Switch to ReadScreenIntoImageSurface for Layers pixel reads

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: Now without cruft from patches it was on top of...

Accidentally built this on top of another patch. Here's the rebased version.

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 652888 [details] [diff] [review]
Now without cruft from patches it was on top of...

Review of attachment 652888 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/opengl/CanvasLayerOGL.cpp
@@ +208,5 @@
>          GetTempSurface(size, gfxASurface::ImageFormatARGB32);
>  
> +      updatedAreaImageSurface->Flush();
> +      mCanvasGLContext->ReadScreenIntoImageSurface(updatedAreaImageSurface);
> +      updatedAreaImageSurface->MarkDirty();

Good catch with the flush/markdirty.

Comment 5

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/68f2ac456dbc

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/68f2ac456dbc