Closed
Bug 78367
Opened 25 years ago
Closed 24 years ago
History list not updated after theme switch
Categories
(Core Graveyard :: Skinability, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
Future
People
(Reporter: morse, Assigned: hyatt)
References
Details
(Whiteboard: [Hixie-P0] fix in hand)
Attachments
(2 files)
|
3.51 KB,
patch
|
Details | Diff | Splinter Review | |
|
1.77 KB,
patch
|
Details | Diff | Splinter Review |
I'm not talking about session history but rather total browser history.
1. Bring up browser
2. view -> apply theme -> classic (or any other one you like)
3. visit any page you like
4. task -> tools -> history
5. Open the "today" section
The page you visited is not listed there.
Comment 1•25 years ago
|
||
Alec, any idea? Need to re-hookup global history on theme switching?
Comment 2•25 years ago
|
||
ack! no, we shouldn't have to - I don't understand how these things are
affecting each other..
Comment 3•25 years ago
|
||
nominating for nsbeta1
Comment 4•25 years ago
|
||
How is this a beta stopper? Please explain why this is nominated for beta?
Updated•25 years ago
|
Priority: -- → P3
Target Milestone: mozilla0.9.2 → mozilla0.9.3
I've verified on commerical builds for Mac (2001-05-29-08-trunk),
windows 98 (2001-05-29-09-trunk), and Linux (2001-05-29-05-trunk),
the history list for "Today" still not updated yet.
Comment 6•25 years ago
|
||
I also see this bug on Win98, build ID 2001053004
Comment 8•25 years ago
|
||
Pushing out for now because visual c++ is screwing me (and soon theme switches
will require a restart)
Status: NEW → ASSIGNED
Target Milestone: mozilla0.9.3 → mozilla1.0
Comment 9•25 years ago
|
||
Okay, bringing back in, I have a couple possible fixes here. Need to talk to
jag about something first.
Target Milestone: mozilla1.0 → mozilla0.9.3
Comment 10•25 years ago
|
||
Comment 11•25 years ago
|
||
Comment 12•25 years ago
|
||
Alec, why do you say we shouldn't have to rehookup global history? It seems
correct to me since the old docshell has been torn down. We were already doing
this anyways, in ReinitializeContentVariables, but I think jag did something so
that that's no longer called on theme switch (that's what I need to ask him
about...)
Whiteboard: fix in hand
Comment 13•25 years ago
|
||
while I applaud the effort, I don't think it's right to create this kind of
dependancy... what we'd like to do is have the docshell lazily instantiate
global history - but only do lazy instantiation once per docshell, and remember
if it failed.
that should solve this problem..
Comment 14•25 years ago
|
||
Probably; how would you go about doing that, more specifically?
(btw, this is somewhat lazily - we do this in ::CheckForBrowser, which is only
called upon ::DoLoadURL)
Comment 15•25 years ago
|
||
Err, disregard my comment about it being somewhat lazy...
Comment 16•25 years ago
|
||
I mean in nsDocShell.cpp, instead of using SetGlobalHistory() to set history, we
should be actually doing a do_GetService in nsDocShell.cpp (in fact, it used to
be the other way, as you'll see in some comments there)
but when we do create it, we have to make sure to use the contractID and not the
CID - that is how we are making it pluggable, as per a conversation with jud
w.r.t. embedding requirements.
Updated•25 years ago
|
Target Milestone: mozilla0.9.3 → mozilla1.0
Updated•25 years ago
|
Whiteboard: fix in hand → [Hixie-P0] fix in hand
Comment 17•25 years ago
|
||
future until dynamic switching is back in style.
Target Milestone: mozilla1.0 → Future
| Assignee | ||
Comment 19•24 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 20•24 years ago
|
||
Since url bar is broken after switching theme, so it's hard to verify the
history list (2001-12-20-09-trunk). Will wait until switching theme issue is
fixed and verified it later.
Updated•18 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•