68973 - [META] skin switch problems

Status: RESOLVED FIXED

(Core Graveyard :: Skinability, defect, P2)

Description

[ratman]

this is a meta bug for problems encountered upon skin/theme switch (before
restart).  feel free to add as you deem fit.

Comment 1

[ratman]

can someone confirm and/or accept this?

Comment 2

[ratman]

i have noticed the common theme with these bugs is that opening a new window
after skin switch generally corrects the problem, as long as the originally used
window(s) is/are closed or not returned to.

would it be possible to simply open a new browser window (and then close the old
one) on skin change?  of course, this leaves out the issue of skin switches in
mail/news and chatzilla, not to mention any already open browser windows, but it
seems like the general concept would correct all of these bugs.

Comment 3

[timeless]

no that's dataloss. we might be able to change the menubar to show italics or 
somehow indicate that the window is likely to be broken..

Comment 4

[ratman]

could a "lesser dataloss" situation be provided instead, where the new window
would open the focused url and some type of warning (a simple okay/cancel alert)
be placed on to the skin switch process warning of dataloss rather than browser
dysfunction?

Comment 5

[Paul Chen]

Marking nsbeta1+, p2, mozilla0.9.1, reassigning to pchen so that I can worry
about it

Comment 6

[Paul Chen]

nav triage team:

Adding Todd Pringle to cc list.

Comment 7

[hangas]

adding 75184

Comment 8

[Todd Pringle]

adding 43350

Comment 9

[Stephen P. Morse]

Adding bug 45813

Comment 10

[andreww]

*** Bug 78549 has been marked as a duplicate of this bug. ***

Comment 11

[selmer (gone)]

It's time to let this go in favor of putting back the dialog warning people to
close all windows with data that might be lost before completing the theme
switch.  Either that, or don't allow the switch until next restart.  We need to
get this off the beta stopper radar.

Comment 12

[doctor__j]

Hmmm...  Can't get as cool as Winamp to switch skins in real time.  Anyway...

Comment 13

[Paul Chen]

Since all the targeted bugs tracked here have at least mozilla0.9.2, moving this
tracking bug to mozilla0.9.3

Comment 14

[ratman]

i disagree with selmer on this one, contrary to my previous comments.  the grand
majority of skin switch problems have been fixed, and really only bug 43350 and
bug 61991 are significant enuf to hold up a beta build.  and without
documentable dataloss being caused, there really isn't a good enuf reason to
skip out with just a warning.

therefore, i would suggest setting target milestone to moz1.0 (to match bug
43350), and dropping nsbeta1+ after the aforementioned bugs (43350, 61991) get
fixed.

Comment 15

[Paul Chen]

nav triage team:

Adding 78367 to dependency list

Comment 16

[gabriel]

Adding 82588 and 85625.

Comment 17

[Paul Chen]

nav triage team:

Pushing out to mozilla1.0 as we currently defer skin switch until restart of app

Comment 18

[Hixie (not reading bugmail)]

What's the bug number for the fact that we can't switch themes on the fly at 
the moment?

Comment 19

[Paul Chen]

moving up to mozilla0.9.9

Comment 20

[David Hyatt]

--> me.

Comment 21

[Håkan Waara]

All the dependencies on this bug are fixed!  Should we mark this meta bug fixed
now as well?

Comment 22

[Håkan Waara]

Ok, marking as such.