783729 - Debugger: JS scripts can get HTML syntax highlighting

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Thaddee Tyl [:espadrine]]

When a JS script does not send the content type,
the debugger gives it HTML syntax highlighting.
(debugger-controller.js 962:19)

This behaviour is suboptimal, and all other browsers I have tested
correctly give it a JS syntax highlighting.

I believe simply checking whether the first non-whitespace character is "<"
is enough to determine whether the file is HTML or JS.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

A missing content type should result in the decision being based on the file name extension. Do you have a test case to reproduce the problem?

Comment 2

[Thaddee Tyl [:espadrine]]

What a <script> links to is always a script file, even if it doesn't have the extension.

Firefox knows that, and Chrome, Safari and Opera show the correct highlighting.
Also, Opera shows the name in unicode, not URL-escaped, although this is not
directly related to this bug.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

I agree that this is a legitimate issue, I only wanted a test case to pinpoint the right place for the fix. Unfortunately, when the script is transferred through the remote protocol it doesn't contain any indication that it was loaded from a script tag.

Comment 4

[Thaddee Tyl [:espadrine]]

Test case: http://espadrine.github.com/%E2%9A%92/

Please note that this bug is of very low priority :)

Comment 5

[Victor Porof [:vporof][:vp]]

When we decide on the content type, we always have the source text fetched, so it should be trivial to simply check if the first character is a "<" or not. I'll play with this a bit.

Comment 6

[Victor Porof [:vporof][:vp]]

Attachment: v1

easy peasy

Comment 7

[Victor Porof [:vporof][:vp]]

https://tbpl.mozilla.org/?tree=Try&rev=02afde8f5b7a

Comment 8

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 675966 [details] [diff] [review]
v1

+      // Use HTML mode for files in which the first non whitespace character is
+      // <, regardless of extension.
+      this.editor.setMode(SourceEditor.MODES.HTML);

yeah.

... banana.

Comment 9

[Victor Porof [:vporof][:vp]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #8)
> Comment on attachment 675966 [details] [diff] [review]

Thanks!

Comment 10

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/d77dedee61fd

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d77dedee61fd