793375 - Search operator for finding a variable in scope(s) while the debugger is paused

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Victor Porof [:vporof][:vp]]

I'm thinking * or &, but other suggestions are encouraged.

Comment 1

[Victor Porof [:vporof][:vp]]

On this note, would it be useful to show the variables in the global scope if the debugger is paused? Probably not that hard to implement, and could make up for a nicer ux than with the console.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

I think this will make a useful feature, if can avoid running into weird issues that stem from getting the window state outside of the Debugger API. I haven't been able to come up with anything not fixable while discussing this with Victor, though.

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #2)
> I think this will make a useful feature, if can avoid running into weird
> issues that stem from getting the window state outside of the Debugger API.
> I haven't been able to come up with anything not fixable while discussing
> this with Victor, though.

Ok, let's just add the operators for now and follow up on the show-global-scope-when-paused-with-no-stacks idea after getting more opinions on it.

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: v1

Works, just missing a small test (although the heavy testing is done in bug 798874).

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: v2

Added tests.

Comment 6

[Victor Porof [:vporof][:vp]]

Attachment: v3

https://tbpl.mozilla.org/?tree=Try&rev=1881a8f07759

Comment 7

[Victor Porof [:vporof][:vp]]

Comment on attachment 675981 [details] [diff] [review]
v3

Sorry Panos :)

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 675981 [details] [diff] [review]
v3

Review of attachment 675981 [details] [diff] [review]:
-----------------------------------------------------------------

My only gripe is that displaying both search boxes at the same time may surprise users when they discover that only one of them is active at any one time. It's good that we don't display the second one by default and I can imagine that some people might prefer it (hey, others like tabs-on-bottom), but it could be a bit confusing. But let's ship it and see what they think.

::: browser/devtools/debugger/debugger-toolbar.js
@@ +886,5 @@
> +      return;
> +    }
> +
> +    let editor = DebuggerView.editor;
> +    let offset = editor[["findNext", "findPrevious"][action]](true);

Really? I mean, seriously?

Comment 9

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #8)
> Comment on attachment 675981 [details] [diff] [review]
> v3
> 
> Review of attachment 675981 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> My only gripe is that displaying both search boxes at the same time may
> surprise users when they discover that only one of them is active at any one
> time. It's good that we don't display the second one by default and I can
> imagine that some people might prefer it (hey, others like tabs-on-bottom),
> but it could be a bit confusing. But let's ship it and see what they think.
> 

I think you have a point. One solution would be to disable the operator when the variables view searchbox is displayed. But, as you said, let's see if anyone complains.

Comment 10

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/f516f7731d22

Comment 11

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/f516f7731d22