The default bug view has changed. See this FAQ.

ArchiveInputStream::Tell incorrectly uses mStatus as an nsresult

RESOLVED FIXED in mozilla17

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

Trunk
mozilla17
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Bug 781153 added this:

  NS_IMETHODIMP
  ArchiveInputStream::Tell(PRInt64 *aResult)
  {
    if (NS_FAILED(mStatus))
      return mStatus;

    LL_UI2L(*aResult, mData.cursor);
    return NS_OK;
  }

mStatus is defined as:

   enum {
     NotStarted,
     Started,
     Done
   } mStatus;

So NS_FAILED() will always return false here.
Created attachment 653157 [details] [diff] [review]
Patch
Attachment #653157 - Flags: review?(jst)
Comment on attachment 653157 [details] [diff] [review]
Patch

This is fine with me, but I'm going to defer the actual review to Andrea who wrote this code.
Attachment #653157 - Flags: review?(jst) → review?(amarchesini)
Comment on attachment 653157 [details] [diff] [review]
Patch

right!
Attachment #653157 - Flags: review?(amarchesini) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/26da3bdbf618
Flags: in-testsuite-
OS: Linux → All
Hardware: x86 → All
https://hg.mozilla.org/mozilla-central/rev/26da3bdbf618
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.