783863 - ArchiveInputStream::Tell incorrectly uses mStatus as an nsresult

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Bug 781153 added this:

  NS_IMETHODIMP
  ArchiveInputStream::Tell(PRInt64 *aResult)
  {
    if (NS_FAILED(mStatus))
      return mStatus;

    LL_UI2L(*aResult, mData.cursor);
    return NS_OK;
  }

mStatus is defined as:

   enum {
     NotStarted,
     Started,
     Done
   } mStatus;

So NS_FAILED() will always return false here.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Patch

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 653157 [details] [diff] [review]
Patch

This is fine with me, but I'm going to defer the actual review to Andrea who wrote this code.

Comment 3

[Andrea Marchesini [:baku]]

Comment on attachment 653157 [details] [diff] [review]
Patch

right!

Comment 4

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/26da3bdbf618

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/26da3bdbf618