784075 - Contacts API: DB upgrade error

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gregor Wagner [:gwagner]]

There might be some error in the recently added upgrade schema code:
E/GeckoConsole( 313): [JavaScript Error: "[Exception... "'TypeError: cursor.value.properties.impp is null' when calling method: [nsIDOMEventListener::handleEvent]" nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)" location: "native frame :: :: :: line 0" data: no]"]
E/GeckoConsole( 313): Content JS ERROR at app://contacts.gaiamobile.org/js/contacts.js:914 in onerror: Error saving contact

Comment 1

[Andrew Overholt [:overholt]]

Gregor, will this only affect current testers?

Comment 2

[Gregor Wagner [:gwagner]]

(In reply to Andrew Overholt [:overholt] from comment #1)
> Gregor, will this only affect current testers?

Yes, but it is still scary to have some DB upgrade code in there that might be wrong.

Comment 3

[Andrew Overholt [:overholt]]

(In reply to Gregor Wagner [:gwagner] from comment #2)
> (In reply to Andrew Overholt [:overholt] from comment #1)
> > Gregor, will this only affect current testers?
> 
> Yes, but it is still scary to have some DB upgrade code in there that might
> be wrong.

I agree, but is it scary enough that we'd hold the release until we fixed it?

Comment 4

[Gregor Wagner [:gwagner]]

(In reply to Andrew Overholt [:overholt] from comment #3)
> (In reply to Gregor Wagner [:gwagner] from comment #2)
> > (In reply to Andrew Overholt [:overholt] from comment #1)
> > > Gregor, will this only affect current testers?
> > 
> > Yes, but it is still scary to have some DB upgrade code in there that might
> > be wrong.
> 
> I agree, but is it scary enough that we'd hold the release until we fixed it?

I would say yes. 
If we are in production and just copy and paste existing code we can loose all contacts of a phone.

Comment 5

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 6

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1af3aa614b6d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1af3aa614b6d