784112 - Debugger cannot distinguish multiple instances of the same file in different iframes

Status: NEW

(DevTools :: Debugger, defect, P3)

Description

[Rob Campbell [:rc] (:robcee)]

The scripts dropdown in the debugger will display only one instance of a source file if it's included multiple times via different iframes. There's no way to debug a specific script / iframe context.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Bug 637572 may provide a nice way to fix this.

Comment 3

[Eddy Bruel [:ejpbruel]]

This seems to be the underlying cause of bug 863078 as well.

Comment 4

[Sebastian Zartner [:sebo]]

Attachment: test case

I've attached a simple test case to make it easier to reproduce the issue.

In that test case, script.js should be listed twice within the Sources panel, once for main.html and once for iframe.html.

Sebastian

Comment 5

[Jason Laster [:jlast]]

Adding this to dbg-sources as I'm not sure we cover all of these cases.

Comment 6

[Logan Smyth [:loganfsmyth]]

Yeah we definitely don't handle this right now. Since the thread actor doesn't have a concept of nested frames, the list of sources is just per-thread, so the client will merge multiple source actors for a file into one source in the tree.

I think this all goes back to really deciding how we want to distinguish the overall tree of frames & assets. In a perfect world each source would be associated with a frame, and the debugger's left-hand tree would be a tree of frames, not just a list of sources-per-thread.

We may be able to implement this with the introductionScript and element fields on the Debugger.Source objects, but I don't know 100% for sure.