browserIter.docShell is undefined errors

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Gavin, Assigned: jaws)

Tracking

Trunk
Firefox 17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Fx17])

Attachments

(2 attachments, 1 obsolete attachment)

These are showing up in tests and sometimes in normal use as well. I think it's caused by us trying to access the docshell too shortly after document insertion of the iframe.
Whiteboard: [Fx17]
Created attachment 653965 [details] [diff] [review]
Patch

This sets isAppTab to true when the panel is opened.

I tried adding a separate "load" event listener within updateButton but I still got iframe.docShell undefined errors (not sure why though). This patch works though without generating the errors.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #653965 - Flags: review?(felipc)
Created attachment 653966 [details] [diff] [review]
Patch (part 2)

This patch renames the variables from notifBrowser to notificationFrame (and related changes). Just some cleanup that Gavin did while looking at this bug.

r=me, author=gavin
Attachment #653966 - Flags: review+
Comment on attachment 653965 [details] [diff] [review]
Patch

Review of attachment 653965 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-social.js
@@ +446,5 @@
>      });
>  
>      panel.addEventListener("popupshown", function onpopupshown() {
>        panel.removeEventListener("popupshown", onpopupshown);
>        SocialToolbar.button.setAttribute("open", "true");

if notifBrowser.contentDocument exists, notifBrowser.docShell should exist as well. So you could set it unconditionally outside the if. But perhaps you have tried it and it didn't work?
Created attachment 653977 [details] [diff] [review]
Patch v2 (part 1)

Thanks, I just didn't think of that. I tested it and it works fine.
Attachment #653965 - Attachment is obsolete: true
Attachment #653965 - Flags: review?(felipc)
Attachment #653977 - Flags: review?(felipc)
Attachment #653977 - Flags: review?(felipc) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0d826d18cec
https://hg.mozilla.org/integration/mozilla-inbound/rev/903124068c07

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d0d826d18cec
https://hg.mozilla.org/mozilla-central/rev/903124068c07
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
You need to log in before you can comment on or make changes to this bug.