page-mod tests hang for Fennec

RESOLVED FIXED

Status

Add-on SDK
General
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: erikvold, Assigned: erikvold)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Blocks: 777632
No longer blocks: 777632

Updated

5 years ago
Priority: -- → P1
Blocks: 787352
Blocks: 787718
Assignee: nobody → evold
Depends on: 772663
I consider this bug for "make page-mod unit test passes on Fennec" or similar (I need a bug number to add to skipped unit test in Fennec, see bug 804187)
Created attachment 714294 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/793

Pointer to Github pull-request
Comment on attachment 714294 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/793

I figure we'll need these tests for bug 834960
Attachment #714294 - Flags: review?(poirot.alex)
Blocks: 834960
Comment on attachment 714294 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/793

Tested on device, works fine.

I asked your various question for clarification, would need one more cycle.
Attachment #714294 - Flags: review?(poirot.alex)
Attachment #714294 - Flags: review?(poirot.alex)
Comment on attachment 714294 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/793

Looks good, thanks for your hard work on supporting mobile,
you make the difference!
Attachment #714294 - Flags: review?(poirot.alex) → review+

Comment 6

5 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/bb751291552b5b529d69f50be35564a015f36557
Bug 784224: Page-mod tests now work on Fennec

https://github.com/mozilla/addon-sdk/commit/04ca75e0d8bd6dd2d8e7f309c99b1280b86a1bf6
bug 784224: addressing review comments

https://github.com/mozilla/addon-sdk/commit/084d13d6294e775044a9a4e07bba636fe40a1aff
bug 784224: removing unnecessary use of rawTabNS

https://github.com/mozilla/addon-sdk/commit/39e72837c57b3080838d0c02c69cc0de27252574
bug 784224: making a more clear separation between tabs/utils and tabs/helpers

https://github.com/mozilla/addon-sdk/commit/133c45791de94125e39b98aa11e3d8a9153e0153
Merge pull request #793 from erikvold/784224-2

Fix Bug 784224: Page-mod tests now work on Fennec r=@ochameau

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 7

5 years ago
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/0afaa2bdb47a7eb68f836e72f67d48731d490bf4
Merge pull request #793 from erikvold/784224-2

Fix Bug 784224: Page-mod tests now work on Fennec r=@ochameau(cherry picked from commit 133c45791de94125e39b98aa11e3d8a9153e0153)

Conflicts:
	lib/sdk/tabs/utils.js
	test/test-page-mod.js
Blocks: 852338
You need to log in before you can comment on or make changes to this bug.