784262 - Use generic install/copy rule in rules.mk

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Use generic install/copy rule in rules.mk

I suspect this will make incremental builds on windows much faster.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Use generic install/copy rule in rules.mk

Forgot to change a variable in preprocessor template.

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 653673 [details] [diff] [review]
Use generic install/copy rule in rules.mk

Erm... broke clobber builds (worked as incremental)

Comment 4

[Mike Hommey [:glandium]]

Attachment: Use generic install/copy rule in rules.mk

This works better, although it required a trick: don't build nsinstall directly, but build nsinstall_real and move it. Without this, there's actually a race condition where the file is there, but it actually doesn't work properly (i got segfaults on linux builds). Making all the install rules depend on nsinstall could also work, but with -jn, we end up building it several times in parallel, so another trick is to use nsinstall.py while nsinstall is building.

https://tbpl.mozilla.org/?tree=Try&rev=7c7c3b6aa98b

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/40e82036f9ec

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/40e82036f9ec

Comment 7

[Rain [:rain1] (inactive)]

Backed out because of Pymake bustage and GNU Make "warning: overriding commands for target".

http://hg.mozilla.org/mozilla-central/rev/790fb17b1fe3

Comment 8

[Mike Hommey [:glandium]]

Attachment: Use generic install/copy rule in rules.mk.

This changes a few things: this avoids duplicate rules for EXPORTS and XPIDLSRCS where there are duplicates between EXPORTS and SDK_HEADERS or XPIDLSRCS and SDK_XPIDLSRCS, which is why we had to backout, removes some export rules in config/Makefile.in, and avoid breaking comm-central because ldap/c-sdk uses nsinstall from dist/bin.

Comment 9

[Mike Hommey [:glandium]]

Attachment: Additional patch for pymake

EXPORTS_mozilla/ipc contains SharedMemoryBasic_chromium.h twice on non-android.

Comment 10

[Mike Hommey [:glandium]]

Attachment: Additional patch for pymake

More duplicates.

Comment 11

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d5efeb13af4

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1d5efeb13af4