788954 - Race condition installing nsIZipWriter.idl

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

make -C zipwriter export
nsIZipReader.idl
make[7]: Entering directory `/builds/slave/m-cen-lnx64/build/obj-firefox/modules/libjar/zipwriter/public'
mkdir -p /builds/slave/m-cen-lnx64/build/obj-firefox/modules/libjar/zipwriter/public/.deps
/builds/slave/m-cen-lnx64/build/obj-firefox/_virtualenv/bin/python /builds/slave/m-cen-lnx64/build/config/pythonpath.py \
	  -I/builds/slave/m-cen-lnx64/build/other-licenses/ply \
	  /builds/slave/m-cen-lnx64/build/obj-firefox/dist/sdk/bin/header.py -I/builds/slave/m-cen-lnx64/build/modules/libjar -I../../dist/idl /builds/slave/m-cen-lnx64/build/modules/libjar/nsIZipReader.idl -d .deps/nsIZipReader.h.pp -o _xpidlgen/nsIZipReader.h
/builds/slave/m-cen-lnx64/build/obj-firefox/config/nsinstall -R -m 644 /builds/slave/m-cen-lnx64/build/modules/libjar/zipwriter/public/nsIZipWriter.idl ../../../../dist/idl
make[6]: Entering directory `/builds/slave/m-cen-lnx64/build/obj-firefox/modules/libjar/zipwriter'
make -C public export
nsIJARChannel.idl
/builds/slave/m-cen-lnx64/build/obj-firefox/_virtualenv/bin/python /builds/slave/m-cen-lnx64/build/config/pythonpath.py \
	  -I/builds/slave/m-cen-lnx64/build/other-licenses/ply \
	  /builds/slave/m-cen-lnx64/build/obj-firefox/dist/sdk/bin/header.py -I/builds/slave/m-cen-lnx64/build/modules/libjar -I../../dist/idl /builds/slave/m-cen-lnx64/build/modules/libjar/nsIJARChannel.idl -d .deps/nsIJARChannel.h.pp -o _xpidlgen/nsIJARChannel.h
make[7]: Entering directory `/builds/slave/m-cen-lnx64/build/obj-firefox/modules/libjar/zipwriter/public'
mkdir -p _xpidlgen/
mkdir -p .deps/
/builds/slave/m-cen-lnx64/build/obj-firefox/config/nsinstall -R -m 644 /builds/slave/m-cen-lnx64/build/modules/libjar/zipwriter/public/nsIZipWriter.idl ../../../../dist/idl
nsIJARURI.idl
make[7]: Leaving directory `/builds/slave/m-cen-lnx64/build/obj-firefox/modules/libjar/zipwriter/public'
make -C src export-idl
make[7]: Entering directory `/builds/slave/m-cen-lnx64/build/obj-firefox/modules/libjar/zipwriter/src'
mkdir -p /builds/slave/m-cen-lnx64/build/obj-firefox/modules/libjar/zipwriter/src/.deps
make[7]: Leaving directory `/builds/slave/m-cen-lnx64/build/obj-firefox/modules/libjar/zipwriter/src'
make -C test export-idl
make[7]: Entering directory `/builds/slave/m-cen-lnx64/build/obj-firefox/modules/libjar/zipwriter/test'
make[7]: `export-idl' is up to date.
make[7]: Leaving directory `/builds/slave/m-cen-lnx64/build/obj-firefox/modules/libjar/zipwriter/test'
make[6]: Leaving directory `/builds/slave/m-cen-lnx64/build/obj-firefox/modules/libjar/zipwriter'
make -C test export-idl
/builds/slave/m-cen-lnx64/build/obj-firefox/config/nsinstall: cannot make symbolic link /builds/slave/m-cen-lnx64/build/obj-firefox/dist/idl/nsIZipWriter.idl: File exists
make[7]: *** [../../../../dist/idl/nsIZipWriter.idl] Error 1
make[7]: *** Deleting file `../../../../dist/idl/nsIZipWriter.idl'

Comment 1

[Mike Hommey [:glandium]]

Basically, both these commands happen at the same time:
- make -C zipwriter export-idl
- make -C zipwriter export

What I don't get is where does the export-idl one come from.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=15006018&tree=Mozilla-Inbound
OS X 10.7 mozilla-inbound build [busted]

Comment 3

[Mike Hommey [:glandium]]

Attachment: Avoid export-idl rule being recursed when doing the export rule

So, what is going on is that make export is recursing, and it also depends on export-idl, which is recursing too.
An alternative solution would be to remote the export-idl rule altogether, if no one uses it. The build system itself doesn't, really.

Comment 4

[Rain [:rain1] (inactive)]

Where's XPIDLSRCS_TARGET used?

Comment 5

[Mike Hommey [:glandium]]

Attachment: Remove export-idl rule

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/mozilla-central/rev/9677eb19a6a5