Last Comment Bug 784313 - Replace body[dir="rtl"] with :dir(rtl)
: Replace body[dir="rtl"] with :dir(rtl)
Status: RESOLVED FIXED
[good first bug][mentor=dao][lang=css]
:
Product: Firefox
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 17
Assigned To: Ekanan Ketunuti
:
Mentors:
Depends on: 562169
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-21 05:48 PDT by Dão Gottwald [:dao]
Modified: 2012-08-21 19:09 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (9.22 KB, patch)
2012-08-21 06:11 PDT, Ekanan Ketunuti
dao+bmo: review+
Details | Diff | Splinter Review
patch for check-in (9.21 KB, patch)
2012-08-21 06:56 PDT, Ekanan Ketunuti
ananuti: review+
Details | Diff | Splinter Review

Description Dão Gottwald [:dao] 2012-08-21 05:48:40 PDT
+++ This bug was initially created as a clone of Bug #784279 +++

Bug 562169 implemented the :dir function. We should use that instead of the body[dir="rtl"] selector.

http://mxr.mozilla.org/mozilla-central/search?string=body[dir%3D&find=\.css%24&filter=browser/
Comment 1 Ekanan Ketunuti 2012-08-21 06:11:39 PDT
Created attachment 653731 [details] [diff] [review]
patch
Comment 2 Dão Gottwald [:dao] 2012-08-21 06:31:18 PDT
Comment on attachment 653731 [details] [diff] [review]
patch

>--- a/browser/devtools/layoutview/view.css
>+++ b/browser/devtools/layoutview/view.css

> #element-size {
>   -moz-box-flex: 1;
> }
> 
>-body[dir=rtl] > #header > #element-size {
>+#header > #element-size:dir(rtl) {
>   -moz-box-pack: end;
> }

"#header > " isn't needed any more. r=me with that removed. Thanks!
Comment 3 Ekanan Ketunuti 2012-08-21 06:56:21 PDT
Created attachment 653737 [details] [diff] [review]
patch for check-in
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-08-21 19:09:18 PDT
https://hg.mozilla.org/mozilla-central/rev/0e73660050a4

Note You need to log in before you can comment on or make changes to this bug.