The default bug view has changed. See this FAQ.

Replace body[dir="rtl"] with :dir(rtl)

RESOLVED FIXED in Firefox 17

Status

()

Firefox
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dao, Assigned: Ekanan Ketunuti)

Tracking

Trunk
Firefox 17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=dao][lang=css])

Attachments

(1 attachment, 1 obsolete attachment)

9.21 KB, patch
Ekanan Ketunuti
: review+
Details | Diff | Splinter Review
(Reporter)

Description

5 years ago
+++ This bug was initially created as a clone of Bug #784279 +++

Bug 562169 implemented the :dir function. We should use that instead of the body[dir="rtl"] selector.

http://mxr.mozilla.org/mozilla-central/search?string=body[dir%3D&find=\.css%24&filter=browser/
(Assignee)

Comment 1

5 years ago
Created attachment 653731 [details] [diff] [review]
patch
Assignee: nobody → ananuti
Status: NEW → ASSIGNED
Attachment #653731 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #653731 - Flags: review? → review?(dao)
(Reporter)

Comment 2

5 years ago
Comment on attachment 653731 [details] [diff] [review]
patch

>--- a/browser/devtools/layoutview/view.css
>+++ b/browser/devtools/layoutview/view.css

> #element-size {
>   -moz-box-flex: 1;
> }
> 
>-body[dir=rtl] > #header > #element-size {
>+#header > #element-size:dir(rtl) {
>   -moz-box-pack: end;
> }

"#header > " isn't needed any more. r=me with that removed. Thanks!
Attachment #653731 - Flags: review?(dao) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 653737 [details] [diff] [review]
patch for check-in
Attachment #653731 - Attachment is obsolete: true
Attachment #653737 - Flags: review+
(Reporter)

Comment 4

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/0e73660050a4
https://hg.mozilla.org/mozilla-central/rev/0e73660050a4
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
You need to log in before you can comment on or make changes to this bug.