Closed
Bug 784313
Opened 14 years ago
Closed 14 years ago
Replace body[dir="rtl"] with :dir(rtl)
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 17
People
(Reporter: dao, Assigned: ananuti)
References
Details
(Whiteboard: [good first bug][mentor=dao][lang=css])
Attachments
(1 file, 1 obsolete file)
|
9.21 KB,
patch
|
ananuti
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #784279 +++
Bug 562169 implemented the :dir function. We should use that instead of the body[dir="rtl"] selector.
http://mxr.mozilla.org/mozilla-central/search?string=body[dir%3D&find=\.css%24&filter=browser/
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Attachment #653731 -
Flags: review? → review?(dao)
|
Reporter | |
Comment 2•14 years ago
|
||
Comment on attachment 653731 [details] [diff] [review]
patch
>--- a/browser/devtools/layoutview/view.css
>+++ b/browser/devtools/layoutview/view.css
> #element-size {
> -moz-box-flex: 1;
> }
>
>-body[dir=rtl] > #header > #element-size {
>+#header > #element-size:dir(rtl) {
> -moz-box-pack: end;
> }
"#header > " isn't needed any more. r=me with that removed. Thanks!
Attachment #653731 -
Flags: review?(dao) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #653731 -
Attachment is obsolete: true
Attachment #653737 -
Flags: review+
|
|
Reporter | |
Comment 4•14 years ago
|
||
|
||
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
You need to log in
before you can comment on or make changes to this bug.
Description
•