784397 - Recent Apps list only shows one Webapp

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[Wesley Johnston (:wesj)]

ibarlow noticed that only one app ever shows in his recent apps list. Is this fallout from changing them to all be named "App"? It would be nice if you could have more than one in there.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

Had to dig into the android source, but it turns out that ActivityManagerService uses affinity to determine if two tasks are "unique". We could set it to "" and just always use a unique task (I think, the word task here is confusing...).

This also works and namespaces them a bit, which feels good.

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

Now with code.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 654402 [details] [diff] [review]
Patch

Seems reasonable based on the docs I have seen, We could also try using the same string we use for process as the taskAffinity too, but I'm not sure it's any better of a choice.

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d720637283eb

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 654402 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New apps stuff
User impact if declined: Only one app (including Fennec) ever appears in the Recent apps screen
Testing completed (on m-c, etc.): landed today
Risk to taking this patch (and alternatives if risky):  Very low risk. Only affects mobile webapps. Just changed their "task" which should have no affect on anything but this
String or UUID changes made by this patch: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d720637283eb

Comment 7

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4ac36aa37b18