784503 - Port bug 782739: mouse wheel zoom is lost after tab switch

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

Bug 719320 changed the mouse wheel zoom handling preferences.

Comment 1

[[e-mail]]

Attachment: Possible patch

I will be really annoyed if I have to fix any tests :-P

Comment 2

[Philip Chee]

Comment on attachment 653950 [details] [diff] [review]
Possible patch

Looks slightly more readable than the Firefox version ;)
Passes the STR in Bug 782739

r=me

> I will be really annoyed if I have to fix any tests :-P
I ran the relevant tests. They all pass so you can exhale.

$ MOZ_NO_REMOTE=1 TEST_PATH=content/events/test/test_bug659071.html pymake -C ../objdir-sm/ mochitest-plain

TEST-PASS | unknown test url | failed to reset zoom - 1 should equal 1
TEST-PASS | unknown test url | failed to zoom by ctrl+wheel - 0.8999999761581421 should not equal 1

Passed: 2
Failed: 0
Todo: 0

$ MOZ_NO_REMOTE=1 TEST_PATH=content/events/test/test_wheel_default_action.html  pymake -C ../objdir-sm/ mochitest-plain

Passed: 1426
Failed: 0
Todo: 0

$ MOZ_NO_REMOTE=1 TEST_PATH=content/events/test/test_bug574663.html pymake -C ../objdir-sm/ mochitest-plain

Passed: 8
Failed: 0
Todo: 0

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 653950 [details] [diff] [review]
Possible patch

f+ wrt tests: this patch should hopefully be safe as is...
http://mxr.mozilla.org/comm-central/search?string=setFullZoom&case=on

Comment 4

[[e-mail]]

Pushed comm-central changeset e2930c7682e9.

Comment 5

[Philip Chee]

Comment on attachment 653950 [details] [diff] [review]
Possible patch

I forgot to flip the right flag as well :P