Closed Bug 784503 Opened 8 years ago Closed 8 years ago

Port bug 782739: mouse wheel zoom is lost after tab switch

Categories

(SeaMonkey :: UI Design, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.14

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

Bug 719320 changed the mouse wheel zoom handling preferences.
Attached patch Possible patchSplinter Review
I will be really annoyed if I have to fix any tests :-P
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #653950 - Flags: feedback?(sgautherie.bz)
Attachment #653950 - Flags: feedback?(philip.chee)
Comment on attachment 653950 [details] [diff] [review]
Possible patch

Looks slightly more readable than the Firefox version ;)
Passes the STR in Bug 782739

r=me

> I will be really annoyed if I have to fix any tests :-P
I ran the relevant tests. They all pass so you can exhale.

$ MOZ_NO_REMOTE=1 TEST_PATH=content/events/test/test_bug659071.html pymake -C ../objdir-sm/ mochitest-plain

TEST-PASS | unknown test url | failed to reset zoom - 1 should equal 1
TEST-PASS | unknown test url | failed to zoom by ctrl+wheel - 0.8999999761581421 should not equal 1

Passed: 2
Failed: 0
Todo: 0

$ MOZ_NO_REMOTE=1 TEST_PATH=content/events/test/test_wheel_default_action.html  pymake -C ../objdir-sm/ mochitest-plain

Passed: 1426
Failed: 0
Todo: 0

$ MOZ_NO_REMOTE=1 TEST_PATH=content/events/test/test_bug574663.html pymake -C ../objdir-sm/ mochitest-plain

Passed: 8
Failed: 0
Todo: 0
Attachment #653950 - Flags: feedback?(philip.chee) → feedback+
Comment on attachment 653950 [details] [diff] [review]
Possible patch

f+ wrt tests: this patch should hopefully be safe as is...
http://mxr.mozilla.org/comm-central/search?string=setFullZoom&case=on
Attachment #653950 - Flags: feedback?(sgautherie.bz) → feedback+
Pushed comm-central changeset e2930c7682e9.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.14
Version: unspecified → Trunk
Comment on attachment 653950 [details] [diff] [review]
Possible patch

I forgot to flip the right flag as well :P
Attachment #653950 - Flags: review+
You need to log in before you can comment on or make changes to this bug.