The default bug view has changed. See this FAQ.

Moving from a menu item to another in new menu button causes menu to stay open

RESOLVED FIXED in Thunderbird 18.0

Status

Thunderbird
Toolbars and Tabs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dew, Assigned: mconley)

Tracking

(Blocks: 1 bug, {polish})

17 Branch
Thunderbird 18.0
x86_64
All
polish
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird17+ fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Created attachment 654207 [details]
Both menus open at once.

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20120821092158

Steps to reproduce:

Hovered over the tools menu and moved cursor to the help menu.


Actual results:

Tools menu stayed open while help menu opened.


Expected results:

Tools menu should have disappeared.
The strange is, when you go from Tools menu directly to Help the Tools popup stays. When you go from Tools menu directly to the arrow on the right of the Help menu then the Tools popup closes normally.

mconley, could it be something in the new binding in mailWidget.xml line2690 ff. isn't correct?
Blocks: 650170
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: polish
Blocks: 789417
Assignee: nobody → mconley
OS: Windows 7 → All
Finally figured out what was going on here - Firefox does a little hack that we missed in our port. Patch coming...
Created attachment 660070 [details] [diff] [review]
Patch v1

Firefox's hack happens here:

http://mxr.mozilla.org/comm-central/source/mozilla/browser/base/content/browser-appmenu.inc#14

And it looks like the splitmenu binding appears to require this in order to make menu-closing work properly.

This patch allows us to emulate this.
Comment on attachment 660070 [details] [diff] [review]
Patch v1

Magnus,

How does this look to you?

-Mike
Attachment #660070 - Flags: review?(mkmelin+mozilla)

Comment 5

5 years ago
Comment on attachment 660070 [details] [diff] [review]
Patch v1

Review of attachment 660070 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like the submenu problem is gone, but when moving the mouse between the menus Tools and Help are both highlighted simultaneously until the Help submenu opens. Feels like opening Help is "heavy". Maybe that's not related though...

r=mkmelin, but do add a comment about what it's doing
Attachment #660070 - Flags: review?(mkmelin+mozilla) → review+
(In reply to Magnus Melin from comment #5)
> Comment on attachment 660070 [details] [diff] [review]
> Patch v1
> 
> Review of attachment 660070 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks like the submenu problem is gone, but when moving the mouse between
> the menus Tools and Help are both highlighted simultaneously until the Help
> submenu opens. Feels like opening Help is "heavy". Maybe that's not related
> though...

Yeah, that heaviness is the 600ms delay, and is expected behaviour. Essentially, it gives / reveals the ability for the user to select that individual item ("Help") without exposing its submenu.

It's the same behaviour as Firefox, so I think we'll keep it. I'll add the comment as you requested.

Thanks for the review!

> 
> r=mkmelin, but do add a comment about what it's doing
Created attachment 660205 [details] [diff] [review]
Patch v2 (r+'d by mkmelin)
Attachment #660070 - Attachment is obsolete: true
Attachment #660205 - Flags: review+
status-thunderbird17: --- → affected
tracking-thunderbird17: --- → ?
Comment on attachment 660205 [details] [diff] [review]
Patch v2 (r+'d by mkmelin)

Improves usability and general correctness of the appmenu.
Attachment #660205 - Flags: approval-comm-aurora?
comm-central: https://hg.mozilla.org/comm-central/rev/6b93d9025dcb
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
Attachment #660205 - Flags: approval-comm-aurora? → approval-comm-aurora+
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/1d31223635ef
status-thunderbird17: affected → fixed
tracking-thunderbird17: ? → +
You need to log in before you can comment on or make changes to this bug.