78474 - Dates in ftp directory listing should use locale, not ISO 8601

Status: VERIFIED FIXED

(Core Graveyard :: Networking: FTP, defect)

Description

[Eric.Zurcher]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:0.8.1+) Gecko/20010430
BuildID:    2001043004

The ftp directory listing displays the date stamp of files and directories using
the American date convention (mm/dd/yy). This notation is very ambiguous, and is
not used in most other countries. It would be better to use the ISO 8601 based
notation: yyyy-mm-dd. (Or, perhaps better, determine the "locale" settings for
the current execution platform and environment, and use them.)

Note that ISO 8601 also uses a 24-hour clock, rather than am/pm for time
representation.


Reproducible: Always
Steps to Reproduce:
1.Go to any ftp:// URL


Actual Results:    bin   0  10/30/99 12:00:00 am directory



Expected Results:  bin   0  1999-10-30 00:00:00 directory

Comment 1

[Bradley Baetz]

The dates/times are also in GMT.

Comment 2

[Bradley Baetz]

I have a fix to simply use the current application locale settings.

(As an aside, I note that en_AU doesn't include AM/PM, while en_US does)

Taking.

Comment 3

[Bradley Baetz]

Done as part of bug 78148

Comment 4

[Bradley Baetz]

pushing off - this is too late for 0.9.1

Comment 5

[benc]

Isn't this bug 28540?

Comment 6

[Bradley Baetz (:bbaetz)]

benc: Probably.

The fix in that bug is not correct though (for ftp urls) and at this stage I
can't remember exactly which part of my patch fixed this. :(

Comment 7

[Bradley Baetz (:bbaetz)]

Mass change: Bug 78148 has been checked in, and so it and these dependancies
should have been fixed. If you disagree, please reopen.

Note that the xul view is still enabled for file because of i18n problems. The
bug to fix this is bug 102812.

Comment 8

[robbe]

Not fixed in 0.9.7. Dates still come up in US format which is hard to parse for
non-USians.

Comment 9

[robbe]

Please reopen this. I can't.

Nonfixed as of 0.9.9 (tested on Linux).

Comment 10

[Bradley Baetz (:bbaetz)]

This works for me. What is the output of running the 'locale' command?

Comment 11

[robbe]

Ah I see, you're using strftime("%x") output. This makes some sense, although I
still think users should be able to force ISO dates. But that's probably more in
the realm of the OS.

So I'm reasonably satisfied. Thanks!

Comment 12

[benc]

I'll write some kind of testcase for this and put it into the ftp test case
re-write I have cooking.

Is there an ISO 8601 reference document I should read?

Comment 13

[robbe]

The genuine article costs:
  http://www.iso.ch/iso/en/CatalogueDetailPage.CatalogueDetail?CSNUMBER=26780

There are good overviews of the standard on:
  http://www.cl.cam.ac.uk/~mgk25/iso-time.html
and
  http://www.mcs.vuw.ac.nz/technical/software/SGML/doc/iso8601/ISO8601.html

Comment 14

[benc]

I'm looking at Mozilla 1.3a, Win98:

File: Welcome  1 KB  8/8/00  12:00:00 AM

Per #2, is getting ISO to work (as the summary says) a WONTFOX?

Comment 15

[benc]

I've changed my local to display european style dates, and my ftp output is
still the same as described above. I know I did this correctly because my
mailnews dates are displayed that way.

Is it possible the new parser changed all this code?

Comment 16

[benc]

VERIFIED/fixed.

I've been running my Windows laptop w/ England as the local for about 3
milestones now.

cc: dougt to make sure he is okay w/ the "we don't do ISO dates" update to the
summary.