Excessive left margin in conversation pane

RESOLVED FIXED in Thunderbird 18.0

Status

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: JoeS1, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 18.0
x86
Windows XP
Dependency tree / graph
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird16 fixed, thunderbird17 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Posted image screenshot
Since 20120822 the conversation pane show an excessive left margin.
bug 768919 ?
It looks fine in win 7 on a wide reso monitor, but pretty ugly on my laptop and oldish winxp systems.
Andreas, what do you think about this Bug? 150px may be a little bit wide and gives a lot of white space. We could use 12ch instead of 150px. The advantage would be the width would be adapted depending the font size.
Would a size in % work in this case?
Something like nick is 15% of chat width? Wouldn't this make the nick go in overflow earlier on narrow windows and then harder to recognize?
What about a min-width and a max-width in px or ch, and a width in % ?
(mostly thinking out loud at this point; I'm not saying this is what we should do.)
(In reply to Richard Marti [:Paenglab] from comment #1)
> Andreas, what do you think about this Bug? 150px may be a little bit wide
> and gives a lot of white space. We could use 12ch instead of 150px. The
> advantage would be the width would be adapted depending the font size.

That sounds good to me.
Blocks: 768919
Posted patch patch (obsolete) — Splinter Review
Patch only changing the width to 12ch. This saves on my system 40px. With this width the nick 'cricccoulson' is fully visible. With 10ch it is already shortend and has an ellipsis at the end.

If this patch is used on TB < 17 then calc() needs to be changed to -moz-calc()
Attachment #656129 - Flags: feedback?(nisses.mail)
Attachment #656129 - Flags: feedback?(florian)
Comment on attachment 656129 [details] [diff] [review]
patch

ch seems to give issues with bold text
Attachment #656129 - Flags: feedback?(nisses.mail) → feedback-
Duplicate of this bug: 789690
Posted patch Patch v2Splinter Review
This patch is now using a width of 15% for the pseudo. To make a gap between pseudo and message I used calc(). For TBs <17 this would need -moz-calc(). To help to identify the pseudo when it's abbreviated, hovering it shows now a tooltip.
Assignee: nobody → richard.marti
Attachment #656129 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #656129 - Flags: feedback?(florian)
Attachment #659491 - Flags: ui-review?(nisses.mail)
Attachment #659491 - Flags: review?(florian)
Comment on attachment 659491 [details] [diff] [review]
Patch v2

Looks good to me ui-wise and don't have the issue with boldtext that the previous patch had.
I'm also ok with the labels.
Attachment #659491 - Flags: ui-review?(nisses.mail) → ui-review+
Comment on attachment 659491 [details] [diff] [review]
Patch v2

Should we also take this for Thunderbird 16 and 17?
Attachment #659491 - Flags: review?(florian) → review+
Comment on attachment 659491 [details] [diff] [review]
Patch v2

[Approval Request Comment]
This impoves the display on small screens
Attachment #659491 - Flags: approval-comm-aurora?
[Approval Request Comment]
This improves the display on small screens.

The only change to the other patch is -moz-calc() instead of calc() which is supported beginning with Gecko 17.
Attachment #660862 - Flags: approval-comm-beta?
https://hg.mozilla.org/comm-central/rev/117fc5dee3ee
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
Attachment #659491 - Flags: approval-comm-aurora? → approval-comm-aurora+
Attachment #660862 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.