78484 - javascript error/warning in sidebarOverlay.js ("panel has no properties"(or exception) and "sidebarObj.panels has no properties")

Status: NEW

(SeaMonkey :: Sidebar, defect)

Description

[Henrik Gemal]

JavaScript error:
chrome://communicator/content/sidebar/sidebarOverlay.js line 921: panel has no
properties

build 20010501 on win2k

Comment 1

[Henrik Gemal]

the error happens when clicking "tabs" -> "sidebar directory..." on the sidebar

Comment 2

[Kathleen :Brade]

this should probably be fixed with bug #57651

Comment 3

[Samir Gehani]

If we are calling the "customize sidebar" or "sidebar directory" menu items we
should not call SidebarTogglePanel() or at least return when we recognize by the
id that the menuitem is not a panel.  

Comment 4

[Alex Vincent [:WeirdAl]]

This is the current error from sidebarOverlay.js:

Error: sidebarObj.panels has no properties
Source File: chrome://communicator/content/sidebar/sidebarOverlay.js
Line: 1125

Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.7+) Gecko/20020108

Recommend marking this bug as blocking bug 57651.  I was looking at the warnings
and not the error.

Of course, both are "forest for the trees" symptoms.  Something's broken and I
can't figure out what.

Comment 5

[Henrik Gemal]

clicking "tabs" -> "sidebar directory..."

Error: panel has no properties
Source File: chrome://communicator/content/sidebar/sidebarOverlay.js
Line: 1036

20020117

Comment 6

[Blake Ross]

*** Bug 57651 has been marked as a duplicate of this bug. ***

Comment 7

[Boris Zbarsky [:bzbarsky]]

Some of these are covered in bug 126810 (has a patch).

Comment 8

[Boris Zbarsky [:bzbarsky]]

*** Bug 153237 has been marked as a duplicate of this bug. ***

Comment 9

[José Jeria]

*** Bug 192113 has been marked as a duplicate of this bug. ***

Comment 10

[José Jeria]

Changing summary for easier finding of this bug.

Comment 11

[Vedran Miletic]

retargeting

Comment 12

[Serge Gautherie (:sgautherie)]

This bug currently reports 2 errors
(following bug 57651 comment 13:
"Please put all js errors/warnings that occur in one file into ONE bug report.")

A- "panel has no properties" (description + comment 1, == comment 5)
B- "sidebarObj.panels has no properties" (comment 4)

I'll write about B-:


[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5) Gecko/20031007] (W98SE)

{
Error: sidebarObj.panels has no properties
Source File: chrome://communicator/content/sidebar/sidebarOverlay.js
Line: 834
}

When I tested this today (for the first time),
I was getting it on every v1.5 Browser launch (sidebar hidden),
untill I showed the sidebar (and/or answered 'No' to the 'make Moz the default
browser')...
I can't reproduce it anymore :-<

(Could it be because I installed v1.6a just before testing, sharing the same
profile ?)


[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6a) Gecko/20031030] (BuildId=0...0,
bug 224340#c9) (W98SE)

If I remember well, immediatly before checking with v1.5, v1.6a was not showing
this error...

Comment 13

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6a) Gecko/20031030]
(BuildId=2003110115, bug 224340#c19) (W98SE)

Checking on comment 12, error B-:
Testcase found :->

Reproductible: Allways :-)

0. Install Mozilla. (Do it once, unless you answer Yes/No at step 2)
   [I don't know if/where this information only can be reset,
      since it's not part of the user profile.
    Notice that this information is shared by all installed Moz builds.]

1. (re)Start Mozilla.
2. _Cancel_ the dialog to make it the default browser.
   (This happens after the Personnal Toolbar (and the SideBar) is displayed,
    but before the PT is populated.)

If the SibeBar is Shown (from last Mozilla shutdown): no error;
If it is Hidden: error !

Actual result: (from JS_C)
{
Error: sidebarObj.panels has no properties
Source File: chrome://communicator/content/sidebar/sidebarOverlay.js
Line: 834
}

As I understand it, it's a timing issue:
I guess a "backend" initialization runs its way in all cases,
but when the "frontend" UI is blocked by the dialog, the properties are not yet
defined when needed.


[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5) Gecko/20031007] (W98SE)

Exact same behaviour.


(I never looked into error A- yet.)

Comment 14

[HJ]

This change in SideBarOverlay.xul will prevent two errors:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80070057 (NS_ERROR_ILLEGAL_VALUE) 
[nsIRDFService.GetResource]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"
location: "JS frame :: 
chrome://communicator/content/sidebar/sidebarOverlay.js :: SidebarTogglePanel ::
line 1269"  data: no]

-           <menuitem label="&sidebar.customize.label;"
accesskey="&sidebar.customize.accesskey;"
                      oncommand="SidebarCustomize();" />
-           <menuitem label="&sidebar.sbDirectory.label;"
                      oncommand="BrowseMorePanels();" />
+           <menuitem label="&sidebar.customize.label;"
accesskey="&sidebar.customize.accesskey;"
                      oncommand="event.preventBubble();SidebarCustomize();"/>
+           <menuitem label="&sidebar.sbDirectory.label;"
                      oncommand="event.preventBubble();BrowseMorePanels();"/>

No one seems interested in fixing sidebar bugs these days, they rather wait for
the bird thing, but that doesn't exactly help moz app suit users, right?

Comment 15

[Alex Vincent [:WeirdAl]]

Um, why do we want to prevent the command event from bubbling back up towards
the document?  Sure, this hides the bug, but it doesn't fix the bug.

What if something (either now, or in the future) relies on the command event's
bubbling phase?

Comment 16

[HJ]

Because there's this:

          <menupopup id="sidebar-panel-picker-popup" popupanchor="bottomleft"
            datasources="rdf:null"
            ref="urn:sidebar:current-panel-list"
            oncommand="SidebarTogglePanel(event.target);" >

so my fix is exactly what you need. And *if* anybody ever relies on the bubble
fase at that spot, shoot him/here, because that is stupid!

Comment 17

[Serge Gautherie (:sgautherie)]

Addition to comment 12:

About case A-, see comment 3 too !


Addition to comment 13:

My Sidebar was not actually Hidden (by pressing F9),
but simply "minimized to the left" (by using its right vertical separator).


Addition to comment 14:

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6a) Gecko/20031030]
(BuildId=2003110115, bug 224340#c19) (W98SE)

Testcase: The exception occurs on the A- case of comment 12, every time.
Changing: (Se) Normal -> Major, since we get an exception.

Something else about case A-:
I'm not getting the "panel has no properties" JS error:
is it due to the exception, or is there a more specific testcase to get it ?

Comment 18

[Alex Vincent [:WeirdAl]]

HJ:  Write up a patch, then.  I'm not convinced, but I'm not a reviewer.  So you
don't have to convince me.

Comment 19

[Serge Gautherie (:sgautherie)]

*** Bug 292677 has been marked as a duplicate of this bug. ***

Comment 20

[Serge Gautherie (:sgautherie)]

(In reply to comment #14)
> chrome://communicator/content/sidebar/sidebarOverlay.js :: SidebarTogglePanel ::
> line 1269"  data: no]

I filed bug 412221 about this exception.