mozprofile should set the version for permissions.sqlite

RESOLVED FIXED

Status

defect
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: k0scist, Assigned: mihneadb)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
We currently don't give a schema version to the permissions.sqlite
db :

https://github.com/mozilla/mozbase/blob/master/mozprofile/mozprofile/permissions.py#L231

We should: https://bugzilla.mozilla.org/show_bug.cgi?id=784875

ABICT, this should be version 3:

https://bugzilla.mozilla.org/show_bug.cgi?id=784875#c1
Posted patch add schema version (obsolete) — Splinter Review
Not sure if there's a better way.
Attachment #709129 - Flags: feedback?(jhammel)
(Assignee)

Updated

6 years ago
Assignee: nobody → mihneadb
(Reporter)

Comment 2

6 years ago
Comment on attachment 709129 [details] [diff] [review]
add schema version

I ain't a SQLite expert but I would assume this is sufficient.  Bonus points for writing a test that fails without this patch and passes with.
Attachment #709129 - Flags: feedback?(jhammel) → feedback+
Posted patch also add testSplinter Review
Attachment #709129 - Attachment is obsolete: true
Attachment #709149 - Flags: review?(jhammel)
(Reporter)

Comment 4

6 years ago
And, sure enough, fails without the code change, passes with :)  Awesome job, mihnea!
(Reporter)

Updated

6 years ago
Attachment #709149 - Flags: review?(jhammel) → review+
(Reporter)

Comment 5

6 years ago
pushed: https://github.com/mozilla/mozbase/commit/d9e769d5bcdf5420e92fdf3b43f766e9c9a13520

...and another bug bites the dust
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(In reply to Jeff Hammel [:jhammel] from comment #4)
> And, sure enough, fails without the code change, passes with :)  Awesome
> job, mihnea!

Yes, I checked. Thanks!
You need to log in before you can comment on or make changes to this bug.