Closed Bug 785146 Opened 13 years ago Closed 12 years ago

mozprofile should set the version for permissions.sqlite

Categories

(Testing :: Mozbase, defect)

Product:
Testing
Component:
Mozbase
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: k0scist, Assigned: mihneadb)

References

Details

Attachments

(1 file, 1 obsolete file)

also add test
2.68 KB, patch
k0scist
: review+
Details | Diff | Splinter Review
We currently don't give a schema version to the permissions.sqlite db : https://github.com/mozilla/mozbase/blob/master/mozprofile/mozprofile/permissions.py#L231 We should: https://bugzilla.mozilla.org/show_bug.cgi?id=784875 ABICT, this should be version 3: https://bugzilla.mozilla.org/show_bug.cgi?id=784875#c1
Attached patch add schema version (obsolete) — — Splinter Review
Not sure if there's a better way.
Attachment #709129 - Flags: feedback?(jhammel)
Assignee: nobody → mihneadb
Comment on attachment 709129 [details] [diff] [review] add schema version I ain't a SQLite expert but I would assume this is sufficient. Bonus points for writing a test that fails without this patch and passes with.
Attachment #709129 - Flags: feedback?(jhammel) → feedback+
Attached patch also add test — — Splinter Review
Attachment #709129 - Attachment is obsolete: true
Attachment #709149 - Flags: review?(jhammel)
And, sure enough, fails without the code change, passes with :) Awesome job, mihnea!
Attachment #709149 - Flags: review?(jhammel) → review+
pushed: https://github.com/mozilla/mozbase/commit/d9e769d5bcdf5420e92fdf3b43f766e9c9a13520 ...and another bug bites the dust
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
(In reply to Jeff Hammel [:jhammel] from comment #4) > And, sure enough, fails without the code change, passes with :) Awesome > job, mihnea! Yes, I checked. Thanks!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: