784875 - permissions.sqlite files in talos need to be upgraded

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Mounir Lamouri (:mounir)]

The schema of that file has been upgraded and the upgrade should happen automatically. However, those files (in talos) don't carry the version number which means we don't know the version and assume they are of the latest. We need to upgrade them to v3 and make sure they are marked as v3.

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch

This is equivalent of doing:

ALTER TABLE moz_hosts ADD appId INTEGER;
ALTER TABLE moz_hosts ADD isInBrowserElement INTEGER;
PRAGMA user_version=3;

Comment 2

[Mounir Lamouri (:mounir)]

Comment on attachment 654466 [details] [diff] [review]
Patch

Review of attachment 654466 [details] [diff] [review]:
-----------------------------------------------------------------

Please, redirect to someone else if you are not the right person to review that change.

Comment 3

[Jeff Hammel]

We will want this in the next talos deploy to m-c.

I'm not sure what needs to be changed in the sqlite files.  :mounir, could you maybe point to some documentation?  Or if you have time to make a patch, even better

Comment 4

[Jeff Hammel]

Looks like me beat me to the punch. Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=a40504790c2e

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 654466 [details] [diff] [review]
Patch

Review of attachment 654466 [details] [diff] [review]:
-----------------------------------------------------------------

I can't think of any other permissions or sqlite files that need to be modified.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

try server run is looking good.  jhammel, we need to ensure mozbase has these changes.

From the looks of the changes, we are probably safe allowing this on older versions of firefox as well.

Comment 7

[Jeff Hammel]

landed: http://hg.mozilla.org/build/talos/rev/cb2a2ed6859e

We will need a follow-up to get this and other talos changes running on m-c

Comment 8

[Jeff Hammel]

(In reply to Joel Maher (:jmaher) from comment #6)
> try server run is looking good.  jhammel, we need to ensure mozbase has
> these changes.

ticketed: bug 785146

Comment 9

[Jeff Hammel]

(In reply to Jeff Hammel [:jhammel] from comment #7)
> landed: http://hg.mozilla.org/build/talos/rev/cb2a2ed6859e
> 
> We will need a follow-up to get this and other talos changes running on m-c

https://bugzilla.mozilla.org/show_bug.cgi?id=785249