As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact bugzilla-admin@mozilla.org
Last Comment Bug 785156 - Lock icon should toggle site security popup
: Lock icon should toggle site security popup
Status: RESOLVED FIXED
[mentor=wesj][lang=java]
:
Product: Firefox for Android
Classification: Client Software
Component: General (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 24
Assigned To: Shane Tully (:stully:
:
: Sebastian Kaspari (:sebastian)
Mentors:
: 866496 (view as bug list)
Depends on:
Blocks: 695204
  Show dependency treegraph
 
Reported: 2012-08-23 11:24 PDT by Wesley Johnston (:wesj)
Modified: 2013-05-30 09:07 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (4.66 KB, patch)
2012-08-23 11:24 PDT, Wesley Johnston (:wesj)
margaret.leibovic: review-
Details | Diff | Splinter Review
Make SiteIdentityPopup focusable (1.01 KB, patch)
2013-05-23 12:57 PDT, Shane Tully (:stully:
wjohnston2000: review+
Details | Diff | Splinter Review
02: Make SiteIdentityPopup focusable (1.16 KB, patch)
2013-05-24 09:51 PDT, Shane Tully (:stully:
wjohnston2000: review+
Details | Diff | Splinter Review

Description User image Wesley Johnston (:wesj) 2012-08-23 11:24:00 PDT
Created attachment 654709 [details] [diff] [review]
Patch

Tappping the lock icon should toggle the site security popup, but right now it just shows it. When you tap on the lock icon while the popup is showing, Android hides the popup on touchdown. Then, when the click fires on the lock icon, we show it again, making it appear and disappear. I hate it.

Fixing it was a bit ugly. I had to use a touchlistener and basically set a boolean so that we'd ignore the click. To make that a bit prettier, I used some gestureListener stuff.
Comment 1 User image Wesley Johnston (:wesj) 2012-08-23 11:25:29 PDT
Comment on attachment 654709 [details] [diff] [review]
Patch

I tried to be generic here and it didn't entirely work, but I kinda think its good to keep around in case we can remove it some day.
Comment 2 User image :Margaret Leibovic 2012-08-23 12:08:59 PDT
Comment on attachment 654709 [details] [diff] [review]
Patch

Unfortunately, you'll have to rebase because bug 771380 just landed.
Comment 3 User image :Margaret Leibovic 2012-08-23 17:13:13 PDT
Comment on attachment 654709 [details] [diff] [review]
Patch

I'm just going to r- this because it needs to be updated.
Comment 4 User image Wesley Johnston (:wesj) 2013-04-29 10:04:53 PDT
*** Bug 866496 has been marked as a duplicate of this bug. ***
Comment 5 User image Shane Tully (:stully: 2013-05-23 12:57:26 PDT
Created attachment 753435 [details] [diff] [review]
Make SiteIdentityPopup focusable

Make the SiteIdentityPopup focusable at the suggestion of sirram. This makes the SiteIdentityPopup capture the click event so it is not passed down to the favicon/padlock icon which would have displayed the popup again.
Comment 6 User image Wesley Johnston (:wesj) 2013-05-24 00:10:42 PDT
Comment on attachment 753435 [details] [diff] [review]
Make SiteIdentityPopup focusable

Review of attachment 753435 [details] [diff] [review]:
-----------------------------------------------------------------

Lets add a comment about why we're doing this too. List this bug number as well so that people can refer back. Something like:

// Make this focuscable so that we tapping on the favicon won't reshow the popup. See bug 785156.
Comment 7 User image Shane Tully (:stully: 2013-05-24 09:51:33 PDT
Created attachment 753855 [details] [diff] [review]
02: Make SiteIdentityPopup focusable

Added comment
Comment 8 User image Ryan VanderMeulen [:RyanVM] 2013-05-29 17:58:51 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/3869dc547459
Comment 9 User image Ryan VanderMeulen [:RyanVM] 2013-05-30 09:07:45 PDT
https://hg.mozilla.org/mozilla-central/rev/3869dc547459

Note You need to log in before you can comment on or make changes to this bug.