Second tap on lock icon should dismiss site security doorhanger

RESOLVED DUPLICATE of bug 785156

Status

()

RESOLVED DUPLICATE of bug 785156
6 years ago
6 years ago

People

(Reporter: pretzer, Unassigned)

Tracking

Trunk
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
When the site security (larry) doorhanger is open a tap on the lock icon should dismiss the doorhanger. Right now it's reopend.

Comment 1

6 years ago
Looks like this has been an issue since this was first implemented:
https://bugzilla.mozilla.org/show_bug.cgi?id=695204#c28

I remember that this was tricky because tapping on the icon changes focus and dismissed the popup before the click listener is called, so we can't check to see if the popup is showing and hide it in that case. I'm not sure the best way to approach this bug, but the relevant code is here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/BrowserToolbar.java#307
Yeah, I tried to fix this in bug 785156, but its a bit of a tricky dance with Android. Marking dup since there's more stuff over there.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 785156
You need to log in before you can comment on or make changes to this bug.