866496 - Second tap on lock icon should dismiss site security doorhanger

Status: RESOLVED DUPLICATE of bug 785156

(Firefox for Android Graveyard :: General, defect)

Description

[Peter Retzer (:pretzer)]

When the site security (larry) doorhanger is open a tap on the lock icon should dismiss the doorhanger. Right now it's reopend.

Comment 1

[:Margaret Leibovic]

Looks like this has been an issue since this was first implemented:
https://bugzilla.mozilla.org/show_bug.cgi?id=695204#c28

I remember that this was tricky because tapping on the icon changes focus and dismissed the popup before the click listener is called, so we can't check to see if the popup is showing and hide it in that case. I'm not sure the best way to approach this bug, but the relevant code is here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/BrowserToolbar.java#307

Comment 2

[Wesley Johnston (:wesj)]

Yeah, I tried to fix this in bug 785156, but its a bit of a tricky dance with Android. Marking dup since there's more stuff over there.