Closed Bug 785186 Opened 8 years ago Closed 8 years ago

Use the context menu in the markup panel

Categories

(DevTools :: Inspector, defect)

Product:
DevTools
Component:
Inspector
Version:
13 Branch
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 17

People

(Reporter: dcamp, Unassigned)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file)

v1
6.31 KB, patch
jwalker
: review+
Details | Diff | Splinter Review
Attached patch v1 — — Splinter Review 
This re-enables the context menu in the new markup panel.

Things get a little tricky because the markup panel and inspector don't necessarily agree on the selection (See bug 785180).
Attachment #654733 - Flags: review?(jwalker)
Blocks: 777085
Duplicate of this bug: 785421
Comment on attachment 654733 [details] [diff] [review]
v1

Review of attachment 654733 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/highlighter/inspector.jsm
@@ +1203,5 @@
>          break;
>      }
>    },
>  
> +  // Return the currently-selected node for the purposes of the

If we care about comment style, then we might /**...*/ this.
Attachment #654733 - Flags: review?(jwalker) → review+
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/9b58a0a085ee
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.