785496 - Marketplace app installs 4 shortcuts on dekstop

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Chelsea Novak [:chelsea]]

Screencap attached: http://cl.ly/image/1Y0s1C371Z0N

Galaxy S2 running ICS

Please let me know if you need more details.

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Nightly (08/24) - Screenshot

This is awesome. I can reproduce this on the Galaxy SII too.

STR:

i) With a new profile, launch Nightly
ii) Tap the Mozilla Market Promotion, or visit the Mozilla Marketplace link in about:apps
iii) Wait a couple seconds for the Mozilla Marketplace to load; and tap the opt-in 'Open' in the door-hanger

--
Nightly (08/24)
Samsung Galaxy SII (Android 4.0.4)

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

We're getting into a loop here while we install the webapp. We send a message from HelperApps to java to launch the Marketplace App, which sends a message to us to install the marketplace, which sends a message from HelperApps to launch the app, etc. Apparently it takes about 4 rounds on some devices before the app is installed and we bail out of the loop.

We already have code to launch the app once its installed. This disabled the HelperApps code for callers that pass in a callback.

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7102138abfb0

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 660968 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 741621
User impact if declined: Multiple icons
Testing completed (on m-c, etc.): Landed 9/13
Risk to taking this patch (and alternatives if risky): Low risk. Mobile webapps only (for now since helper apps isn't used by anything else).
String or UUID changes made by this patch: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7102138abfb0

Comment 7

[Andreea Pod]

Verified fixed on: 

Build: Firefox 18.0a1 (2012-09-17)
Device: Samsung Galaxy Nexus
OS: Android 4.1.1

Waiting to land on Aurora also.

Comment 8

[Scoobidiver (away)]

Pushed to Aurora: http://hg.mozilla.org/releases/mozilla-aurora/rev/a4cdf3eb9220

Comment 9

[Andreea Pod]

Verified fixed on: 

Build: Firefox 17.0a2 (2012-09-20)
Device: Samsung Galaxy Nexus
OS: Android 4.1.1