785714 - gclicommand |help jsb| contains hardcoded string for url

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The following string in GcliCommans.jsm should be localized:

{
  name: 'url',
  type: 'string',
  description: gcli.lookup('jsbUrlDesc'),
  manual: 'The URL of the JS to prettify'
},

Comment 1

[Ekanan Ketunuti]

Attachment: patch

Comment 2

[Joe Walker [:jwalker]]

Comment on attachment 655543 [details] [diff] [review]
patch

Review of attachment 655543 [details] [diff] [review]:
-----------------------------------------------------------------

GCLI automatically uses the 'description' field when there isn't a 'manual' entry, so supplying both with the same string doesn't help. I suggest in this case that we just remove the entry for the manual field.
Thanks.

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 655543 [details] [diff] [review]
patch

Review of attachment 655543 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/devtools/gclicommands.properties
@@ +740,5 @@
>  
> +# LOCALIZATION NOTE (jsbUrlManual) A fuller description of the
> +# 'jsb <url>' parameter, displayed when the user asks for help on what it
> +# does.
> +jsbUrlManual=The URL of the JS to prettify

If we're not removing that key, this should be consistently 'beautify'.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Axel Hecht [:Pike] from comment #3)
> If we're not removing that key, this should be consistently 'beautify'.

This will be fixed by bug 782820.

Comment 5

[Ekanan Ketunuti]

Attachment: patch

rm manual string for jsb url.

Comment 6

[Joe Walker [:jwalker]]

Comment on attachment 655829 [details] [diff] [review]
patch

Review of attachment 655829 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Will add this to my landing queue

Comment 7

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Try&rev=95edd1e1af78

Comment 8

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=3636c402ea3d

Comment 9

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/mozilla-central/rev/3ac34e8c7c9b