Closed
Bug 785714
Opened 12 years ago
Closed 12 years ago
gclicommand |help jsb| contains hardcoded string for url
Categories
(DevTools :: Console, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 18
People
(Reporter: aryx, Assigned: ananuti)
Details
(Whiteboard: [gclicommands][fixed-in-fx-team])
Attachments
(1 file, 1 obsolete file)
991 bytes,
patch
|
jwalker
:
review+
|
Details | Diff | Splinter Review |
The following string in GcliCommans.jsm should be localized: { name: 'url', type: 'string', description: gcli.lookup('jsbUrlDesc'), manual: 'The URL of the JS to prettify' },
Assignee | ||
Comment 1•12 years ago
|
||
Comment 2•12 years ago
|
||
Comment on attachment 655543 [details] [diff] [review] patch Review of attachment 655543 [details] [diff] [review]: ----------------------------------------------------------------- GCLI automatically uses the 'description' field when there isn't a 'manual' entry, so supplying both with the same string doesn't help. I suggest in this case that we just remove the entry for the manual field. Thanks.
Comment 3•12 years ago
|
||
Comment on attachment 655543 [details] [diff] [review] patch Review of attachment 655543 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/locales/en-US/chrome/browser/devtools/gclicommands.properties @@ +740,5 @@ > > +# LOCALIZATION NOTE (jsbUrlManual) A fuller description of the > +# 'jsb <url>' parameter, displayed when the user asks for help on what it > +# does. > +jsbUrlManual=The URL of the JS to prettify If we're not removing that key, this should be consistently 'beautify'.
Reporter | ||
Comment 4•12 years ago
|
||
(In reply to Axel Hecht [:Pike] from comment #3) > If we're not removing that key, this should be consistently 'beautify'. This will be fixed by bug 782820.
Assignee | ||
Updated•12 years ago
|
Attachment #655543 -
Attachment is obsolete: true
Attachment #655543 -
Flags: review?(dcamp)
Assignee | ||
Comment 5•12 years ago
|
||
rm manual string for jsb url.
Attachment #655829 -
Flags: review?(jwalker)
Comment 6•12 years ago
|
||
Comment on attachment 655829 [details] [diff] [review] patch Review of attachment 655829 [details] [diff] [review]: ----------------------------------------------------------------- Thanks. Will add this to my landing queue
Attachment #655829 -
Flags: review?(jwalker) → review+
Comment 8•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Fx-Team&rev=3636c402ea3d
Whiteboard: [gclicommands] → [gclicommands][fixed-in-fx-team]
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3ac34e8c7c9b
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Target Milestone: --- → Firefox 18
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•