gclicommand |help jsb| contains hardcoded string for url

RESOLVED FIXED in Firefox 18

Status

DevTools
Console
RESOLVED FIXED
6 years ago
5 days ago

People

(Reporter: aryx, Assigned: Ekanan Ketunuti)

Tracking

16 Branch
Firefox 18

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [gclicommands][fixed-in-fx-team])

Attachments

(1 attachment, 1 obsolete attachment)

991 bytes, patch
jwalker
: review+
Details | Diff | Splinter Review
The following string in GcliCommans.jsm should be localized:

{
  name: 'url',
  type: 'string',
  description: gcli.lookup('jsbUrlDesc'),
  manual: 'The URL of the JS to prettify'
},

Updated

6 years ago
Whiteboard: [gclicommands]
(Assignee)

Comment 1

6 years ago
Created attachment 655543 [details] [diff] [review]
patch
Assignee: nobody → ananuti
Status: NEW → ASSIGNED
Attachment #655543 - Flags: review?(dcamp)
Comment on attachment 655543 [details] [diff] [review]
patch

Review of attachment 655543 [details] [diff] [review]:
-----------------------------------------------------------------

GCLI automatically uses the 'description' field when there isn't a 'manual' entry, so supplying both with the same string doesn't help. I suggest in this case that we just remove the entry for the manual field.
Thanks.

Comment 3

6 years ago
Comment on attachment 655543 [details] [diff] [review]
patch

Review of attachment 655543 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/devtools/gclicommands.properties
@@ +740,5 @@
>  
> +# LOCALIZATION NOTE (jsbUrlManual) A fuller description of the
> +# 'jsb <url>' parameter, displayed when the user asks for help on what it
> +# does.
> +jsbUrlManual=The URL of the JS to prettify

If we're not removing that key, this should be consistently 'beautify'.
(In reply to Axel Hecht [:Pike] from comment #3)
> If we're not removing that key, this should be consistently 'beautify'.

This will be fixed by bug 782820.
(Assignee)

Updated

6 years ago
Attachment #655543 - Attachment is obsolete: true
Attachment #655543 - Flags: review?(dcamp)
(Assignee)

Comment 5

6 years ago
Created attachment 655829 [details] [diff] [review]
patch

rm manual string for jsb url.
Attachment #655829 - Flags: review?(jwalker)
Comment on attachment 655829 [details] [diff] [review]
patch

Review of attachment 655829 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Will add this to my landing queue
Attachment #655829 - Flags: review?(jwalker) → review+
https://tbpl.mozilla.org/?tree=Fx-Team&rev=3636c402ea3d
Whiteboard: [gclicommands] → [gclicommands][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/3ac34e8c7c9b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18

Updated

5 days ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.