785897 - Implement onclick callbacks for Notification Center alerts

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Reuben Morais [:reuben]]

See bug 728106 comment 32, bug 728106 comment 44.

Comment 2

[Florian Bender]

Shouldn't Bug 782211 be blocked by this bug instead of depend on it? Otherwise, if callback support is not necessary for WebNotifications, this bug should not be blocking nor depending.

Comment 3

[Josh Aas]

So far as I know we're not planning to use Notification Center right now. I'm going to WONTFIX this, but we can re-open it if we're going to enable Notification Center.

Comment 4

[Doug Turner (:dougt)]

hmmm... nightly uses the notification center right now.

Didn't you argue we should remove growl support in favor of Notification Center, and if so, why don't you think we should fix this deficiency?  (also if you really mean to not fix this, you should resolve as RESOLVED / WONTFIX).

I think we must fix this so that we can use Notification Center as designed.  Without this bug being fixed, the notifications we post are halfassed.

I'll reopen for consideration.

Comment 5

[Josh Aas]

(In reply to Doug Turner (:dougt) from comment #4)
> hmmm... nightly uses the notification center right now.

I have a patch to disable that in another bug.

> Didn't you argue we should remove growl support in favor of Notification
> Center, and if so, why don't you think we should fix this deficiency?  (also
> if you really mean to not fix this, you should resolve as RESOLVED /
> WONTFIX).

I haven't changed my mind about replacing Growl, I just think we should replace it with the new web notifications work instead of Notification Center.

> I think we must fix this so that we can use Notification Center as designed.
> Without this bug being fixed, the notifications we post are halfassed.

As above, we should fix this with the work in bug 782211 instead of my NC implementation. In order to make my NC implementation work better (fix this bug) we'll need to change our current notification API anyway.

Comment 6

[Nomis101]

Sorry, I don't want to raise a discussion, but I don't get the point. Why do we want to prefer a non-system API (web notifications) to a system-own API (NC)? I'm in favour for integrating the application as much as possible in the OS and prefer to use system-own APIs. Or at least give the user the choice to use it if he wants (with a pref or something). 
I use NC in my own builds for a few month now (and have reenabled it in the newer builds) and I really love it.

Comment 7

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to Josh Aas (Mozilla Corporation) from comment #5)
> I have a patch to disable that in another bug.

That's welcome news! You realize the notification support is in Aurora as well, right?


> I haven't changed my mind about replacing Growl, I just think we should
> replace it with the new web notifications work instead of Notification
> Center.

This sounds excellent, and will really help make notifications functionality in add-ons much more reliable on OS X.

Comment 8

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to Nomis101 from comment #6)
> Sorry, I don't want to raise a discussion, but I don't get the point. Why do
> we want to prefer a non-system API (web notifications) to a system-own API
> (NC)? I'm in favour for integrating the application as much as possible in
> the OS and prefer to use system-own APIs. Or at least give the user the
> choice to use it if he wants (with a pref or something). 
> I use NC in my own builds for a few month now (and have reenabled it in the
> newer builds) and I really love it.

What NC provides diverges from other platforms, what I would prefer instead is a consistent api across platforms that add-on and web developers can rely on to work. I think the w3c spec will get us there.

Comment 9

[Stephen Horlander [:shorlander]]

Will this be needed for bug 852648 ?

Comment 10

[Josh Aas]

Fixed in bug 852648.