785921 - If related screenshots/videos are 404ing, don't show the screenshot block on Consumer pages

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Pick an app where the associated screenshot/video is 404'ing
- https://marketplace-dev.allizom.org/search/?q=packaged
- https://marketplace-dev.allizom.org/app/packaged-mozillaball-%E3%82%87-1/?src=
2. Notice the screenshot section

observed behavior:
If related screenshots/videos are 404ing, don't show the screenshot block on Consumer pages


See attached screenshot.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Wrong screenshot? And why are they 404'ing to begin with?

Comment 2

[Wil Clouser [:clouserw]]

yeah, the problem here are that assets are 404ing.  Is this still a problem or has it been fixed along the way?

Comment 3

[krupa raj[:krupa]]

Attachment: screenshot

We need to compensate for the fact that sometimes uploaded images may get into a wonky state. Ideally, screenshots will never 404 but if they do, we should fail gracefully.

Comment 4

[Wil Clouser [:clouserw]]

(In reply to krupa raj 82[:krupa] from comment #3)
> Created attachment 659387 [details]
> screenshot
> 
> We need to compensate for the fact that sometimes uploaded images may get
> into a wonky state. Ideally, screenshots will never 404 but if they do, we
> should fail gracefully.

Letting something get in a wonky state is unacceptable.  If you have links or STR let's focus on that.  Having things not show up if they are a 404 is a nice idea until you're the developer uploading an image that is mysteriously not showing up.  If it's showing up as a big black blob or as a rainbow of pixels or whatever, that helps them and us know something is wrong.  Remember when people uploaded transparent PNGs and our converter turned the transparent parts black?  It was helpful to know that to track it down.

I'm wontfixing this - we should apply development time to fixing wonkiness, not patching around it.