786118 - xpcom/io/nsLocalFileUnix.cpp -Wdeprecated-declarations 'lstat64' is deprecated: first deprecated in Mac OS X 10.6

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Gregory Szorc [:gps]]

compiling xpcom/io/nsLocalFileUnix.cpp with Clang on OS X Mountain Lion (possibly earlier releases) is spewing the following compiler warnings about deprecated functions being used:

xpcom/io/nsLocalFileUnix.cpp:271:9 [-Wdeprecated-declarations] 'stat64' is deprecated: first deprecated in Mac OS X 10.6
xpcom/io/nsLocalFileUnix.cpp:273:13 [-Wdeprecated-declarations] 'lstat64' is deprecated: first deprecated in Mac OS X 10.6
xpcom/io/nsLocalFileUnix.cpp:1009:9 [-Wdeprecated-declarations] 'lstat64' is deprecated: first deprecated in Mac OS X 10.6
xpcom/io/nsLocalFileUnix.cpp:1048:9 [-Wdeprecated-declarations] 'lstat64' is deprecated: first deprecated in Mac OS X 10.6
xpcom/io/nsLocalFileUnix.cpp:1142:9 [-Wdeprecated-declarations] 'lstat64' is deprecated: first deprecated in Mac OS X 10.6
xpcom/io/nsLocalFileUnix.cpp:1502:9 [-Wdeprecated-declarations] 'lstat64' is deprecated: first deprecated in Mac OS X 10.6
xpcom/io/nsLocalFileUnix.cpp:1574:9 [-Wdeprecated-declarations] 'lstat64' is deprecated: first deprecated in Mac OS X 10.6
xpcom/io/nsLocalFileUnix.cpp:1617:13 [-Wdeprecated-declarations] 'lstat64' is deprecated: first deprecated in Mac OS X 10.6

The man page for stat has some interesting history regarding this function on OS X. I'm not sure what it all translates to in the context of shipping Firefox OS X binaries. All I know is I see some compiler warnings.

Comment 1

[Josh Aas]

Did some research, seems like we should just use stat/lstat on OS X now. OS X 10.6 only supports 64-bit stat/lstat.

The situation is more complicated if you need to target 10.5, but we don't.

Comment 2

[Josh Aas]

Attachment: macstat1.patch

Comment 3

[Josh Aas]

pushed to mozilla-inbound:

http://hg.mozilla.org/integration/mozilla-inbound/rev/3fe96a7f8934

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3fe96a7f8934