786169 - Corrupt non-latin text into debugger

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[ru-vadik]

Attachment: Screenshot

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20100101 Firefox/15.0
Build ID: 20120824154833

Steps to reproduce:

1. Open http://javascript.ru/alert
2. Open debugger
3. Select alert file
4. Go to line 267 into degugger

Result - <td class="thead">ÐоиÑк по ÑоÑÑмÑ</td>


Actual results:

Always.


Expected results:

<td class="thead">Поиск по форуму</td>

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

We have the same issue as the Style Editor. Bug 747820 has code that looks like we could share.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: [in-fx-team] Patch v1

This fixes bug 789778 as well.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Try: https://tbpl.mozilla.org/?tree=Try&rev=6903f23db920

Comment 6

[Mihai Sucan [:msucan]]

Comment on attachment 660005 [details] [diff] [review]
[in-fx-team] Patch v1

Review of attachment 660005 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good. All tests pass. Thanks!

One concern: you only use the channel.contentCharset to determine the correct encoding. Is this sufficient? In the case of CSS there's more code logic to determine the actual charset. This might be for some other day...

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Mihai Sucan [:msucan] from comment #6)
> Patch looks good. All tests pass. Thanks!
> 
> One concern: you only use the channel.contentCharset to determine the
> correct encoding. Is this sufficient? In the case of CSS there's more code
> logic to determine the actual charset. This might be for some other day...

I'm not aware of any other ways (like @charset) to set the charset for scripts. We could file followups if anyone comes up with a problematic case.

Comment 8

[Mihai Sucan [:msucan]]

(In reply to Panos Astithas [:past] from comment #7)
> (In reply to Mihai Sucan [:msucan] from comment #6)
> > Patch looks good. All tests pass. Thanks!
> > 
> > One concern: you only use the channel.contentCharset to determine the
> > correct encoding. Is this sufficient? In the case of CSS there's more code
> > logic to determine the actual charset. This might be for some other day...
> 
> I'm not aware of any other ways (like @charset) to set the charset for
> scripts. We could file followups if anyone comes up with a problematic case.

I'm not aware of such things either, but the page charset might be taken into consideration when the channel content charset is missing. Anyway, let's leave this as is - if someone finds more problematic cases a new bug shall be filed.

Comment 9

[Mihai Sucan [:msucan]]

Comment on attachment 660005 [details] [diff] [review]
[in-fx-team] Patch v1

Landed:
https://hg.mozilla.org/integration/fx-team/rev/07175a2efd99

Comment 10

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/mozilla-central/rev/07175a2efd99