Closed Bug 786169 Opened 8 years ago Closed 8 years ago

Corrupt non-latin text into debugger

Categories

(DevTools :: Debugger, defect, P2)

15 Branch
x86_64
Windows 7
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 18

People

(Reporter: ru-vadik, Assigned: past)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(2 files)

Attached image Screenshot
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20100101 Firefox/15.0
Build ID: 20120824154833

Steps to reproduce:

1. Open http://javascript.ru/alert
2. Open debugger
3. Select alert file
4. Go to line 267 into degugger

Result - <td class="thead">ÐоиÑк по ÑоÑÑмÑ</td>


Actual results:

Always.


Expected results:

<td class="thead">Поиск по форуму</td>
Component: Untriaged → Developer Tools: Debugger
We have the same issue as the Style Editor. Bug 747820 has code that looks like we could share.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Duplicate of this bug: 786910
Summary: Corrupt Cyrilic text into debugger → Corrupt non-latin text into debugger
Assignee: nobody → past
Status: NEW → ASSIGNED
Priority: -- → P2
This fixes bug 789778 as well.
Attachment #660005 - Flags: review?(mihai.sucan)
Duplicate of this bug: 789778
Comment on attachment 660005 [details] [diff] [review]
[in-fx-team] Patch v1

Review of attachment 660005 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good. All tests pass. Thanks!

One concern: you only use the channel.contentCharset to determine the correct encoding. Is this sufficient? In the case of CSS there's more code logic to determine the actual charset. This might be for some other day...
Attachment #660005 - Flags: review?(mihai.sucan) → review+
(In reply to Mihai Sucan [:msucan] from comment #6)
> Patch looks good. All tests pass. Thanks!
> 
> One concern: you only use the channel.contentCharset to determine the
> correct encoding. Is this sufficient? In the case of CSS there's more code
> logic to determine the actual charset. This might be for some other day...

I'm not aware of any other ways (like @charset) to set the charset for scripts. We could file followups if anyone comes up with a problematic case.
(In reply to Panos Astithas [:past] from comment #7)
> (In reply to Mihai Sucan [:msucan] from comment #6)
> > Patch looks good. All tests pass. Thanks!
> > 
> > One concern: you only use the channel.contentCharset to determine the
> > correct encoding. Is this sufficient? In the case of CSS there's more code
> > logic to determine the actual charset. This might be for some other day...
> 
> I'm not aware of any other ways (like @charset) to set the charset for
> scripts. We could file followups if anyone comes up with a problematic case.

I'm not aware of such things either, but the page charset might be taken into consideration when the channel content charset is missing. Anyway, let's leave this as is - if someone finds more problematic cases a new bug shall be filed.
Comment on attachment 660005 [details] [diff] [review]
[in-fx-team] Patch v1

Landed:
https://hg.mozilla.org/integration/fx-team/rev/07175a2efd99
Attachment #660005 - Attachment description: Patch v1 → [in-fx-team] Patch v1
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/07175a2efd99
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.