786278 - mozconfig whitelists need to be updated for 16.0b1

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Chris AtLee [:catlee]]

Hit these in 16.0b1. The extra options for armv6 are ok, and beta builds shouldn't be built with --enable-profiling, so they need to be added to the whitelists.

2012-08-28 07:37:46,858 : ERROR : found in mobile/android/config/mozconfigs/android-armv6/release but not in mobile/android/config/mozconfigs/android-armv6/nightly: ac_add_options --enable-updater
2012-08-28 07:37:46,858 : ERROR : found in mobile/android/config/mozconfigs/android-armv6/release but not in mobile/android/config/mozconfigs/android-armv6/nightly: ac_add_options --enable-official-branding
2012-08-28 07:37:46,858 : ERROR : found in mobile/android/config/mozconfigs/android-armv6/nightly but not in mobile/android/config/mozconfigs/android-armv6/release: ac_add_options --enable-warnings-as-errors
2012-08-28 07:37:46,859 : ERROR : found in mobile/android/config/mozconfigs/android-armv6/nightly but not in mobile/android/config/mozconfigs/android-armv6/release: ac_add_options --with-ccache=/usr/bin/ccache

2012-08-28 07:38:00,004 : WARNING : ac_add_options --enable-profiling not in macosx64 ['ac_add_options --enable-update-channel=nightly', 'ac_add_options --with-macbundlename-prefix=Firefox', 'mk_add_options MOZ_MAKE_FLAGS="-j12
"', 'ac_add_options --with-ccache', 'ac_add_options --enable-codesighs', 'mk_add_options MOZ_MAKE_FLAGS="-j4"', 'ac_add_options --enable-signmar', 'ac_add_options --enable-js-diagnostics', 'ac_add_options --disable-install-stri
p']!
2012-08-28 07:38:00,004 : ERROR : found in browser/config/mozconfigs/macosx-universal/nightly but not in browser/config/mozconfigs/macosx-universal/release: ac_add_options --enable-profiling
2012-08-28 07:38:01,490 : WARNING : ac_add_options --enable-profiling not in win32 ['ac_add_options --enable-update-channel=nightly', 'ac_add_options --enable-signmar', 'ac_add_options --enable-js-diagnostics', '. $topsrcdir/co
nfigs/mozilla2/win32/include/choose-make-flags', 'mk_add_options MOZ_MAKE_FLAGS=-j1', 'if test "$IS_NIGHTLY" != ""; then', 'ac_add_options --disable-auto-deps', 'fi']!
2012-08-28 07:38:01,491 : ERROR : found in browser/config/mozconfigs/win32/nightly but not in browser/config/mozconfigs/win32/release: ac_add_options --enable-profiling
2012-08-28 07:38:02,895 : WARNING : ac_add_options --enable-profiling not in linux64 ['ac_add_options --enable-update-channel=nightly', 'ac_add_options --enable-codesighs', 'mk_add_options MOZ_MAKE_FLAGS="-j4"', 'ac_add_options
 --enable-signmar', 'ac_add_options --enable-js-diagnostics', 'ac_add_options --with-ccache=/usr/bin/ccache', 'export MOZILLA_OFFICIAL=1', 'export MOZ_TELEMETRY_REPORTING=1', "mk_add_options PROFILE_GEN_SCRIPT='$(PYTHON) @MOZ_O
BJDIR@/_profile/pgo/profileserver.py 10'", 'STRIP_FLAGS="--strip-debug"']!
2012-08-28 07:38:02,895 : ERROR : found in browser/config/mozconfigs/linux64/nightly but not in browser/config/mozconfigs/linux64/release: ac_add_options --enable-profiling
2012-08-28 07:38:04,087 : WARNING : ac_add_options --enable-profiling not in linux ['ac_add_options --enable-update-channel=nightly', 'CXX=$REAL_CXX', 'CXX="ccache $REAL_CXX"', 'CC="ccache $REAL_CC"', 'mk_add_options PROFILE_GE
N_SCRIPT=@TOPSRCDIR@/build/profile_pageloader.pl', 'ac_add_options --enable-codesighs', 'mk_add_options MOZ_MAKE_FLAGS="-j4"', 'ac_add_options --enable-signmar', 'ac_add_options --enable-js-diagnostics', 'ac_add_options --with-
ccache=/usr/bin/ccache', 'export MOZILLA_OFFICIAL=1', 'export MOZ_TELEMETRY_REPORTING=1', "mk_add_options PROFILE_GEN_SCRIPT='$(PYTHON) @MOZ_OBJDIR@/_profile/pgo/profileserver.py 10'", 'STRIP_FLAGS="--strip-debug"']!
2012-08-28 07:38:04,087 : ERROR : found in browser/config/mozconfigs/linux32/nightly but not in browser/config/mozconfigs/linux32/release: ac_add_options --enable-profiling

Comment 1

[Chris AtLee [:catlee]]

actually, it turns out that --enable-profiling shouldn't be in the nightly mozconfig, so no need to adjust our whitelists for that.

Comment 2

[[e-mail] (:bhearsum)]

Catlee, assigning this to you since you're on the hook for b1. Throw it back if you think that's wrong.

Comment 3

[Chris AtLee [:catlee]]

Attachment: update whitelists

Comment 4

[Chris AtLee [:catlee]]

Comment on attachment 658146 [details] [diff] [review]
update whitelists

checked in without the changes to master_fabric.py

Comment 5

[Rail Aliiev [:rail]]

Still getting this:

2012-09-04 12:12:37,737 : INFO : Comparing firefox mozconfigs to nightly mozconfigs...
2012-09-04 12:12:39,083 : WARNING : ac_add_options --disable-profiling not in macosx64 ['ac_add_options --enable-update-channel=nightly', 'ac_add_options --with-macbundlename-prefix=Firefox
', 'mk_add_options MOZ_MAKE_FLAGS="-j12"', 'ac_add_options --with-ccache', 'ac_add_options --enable-codesighs', 'mk_add_options MOZ_MAKE_FLAGS="-j4"', 'ac_add_options --enable-signmar', 'ac_add_options --enable-js-diagnostics', 'ac_add_options --disable-install-strip']!
2012-09-04 12:12:39,083 : ERROR : found in browser/config/mozconfigs/macosx-universal/nightly but not in browser/config/mozconfigs/macosx-universal/release: ac_add_options --disable-profiling
2012-09-04 12:12:40,417 : WARNING : ac_add_options --disable-profiling not in win32 ['ac_add_options --enable-update-channel=nightly', 'ac_add_options --enable-signmar', 'ac_add_options --enable-js-diagnostics', '. $topsrcdir/configs/mozilla2/win32/include/choose-make-flags', 'mk_add_options MOZ_MAKE_FLAGS=-j1', 'if test "$IS_NIGHTLY" != ""; then', 'ac_add_options --disable-auto-deps', 'fi']!
2012-09-04 12:12:40,417 : ERROR : found in browser/config/mozconfigs/win32/nightly but not in browser/config/mozconfigs/win32/release: ac_add_options --disable-profiling
2012-09-04 12:12:41,802 : WARNING : ac_add_options --disable-profiling not in linux64 ['ac_add_options --enable-update-channel=nightly', 'ac_add_options --enable-codesighs', 'mk_add_options MOZ_MAKE_FLAGS="-j4"', 'ac_add_options --enable-signmar', 'ac_add_options --enable-js-diagnostics', 'ac_add_options --with-ccache=/usr/bin/ccache', 'export MOZILLA_OFFICIAL=1', 'export MOZ_TELEMETRY_REPORTING=1', "mk_add_options PROFILE_GEN_SCRIPT='$(PYTHON) @MOZ_OBJDIR@/_profile/pgo/profileserver.py 10'", 'STRIP_FLAGS="--strip-debug"']!
2012-09-04 12:12:41,803 : ERROR : found in browser/config/mozconfigs/linux64/nightly but not in browser/config/mozconfigs/linux64/release: ac_add_options --disable-profiling
2012-09-04 12:12:43,045 : WARNING : ac_add_options --disable-profiling not in linux ['ac_add_options --enable-update-channel=nightly', 'CXX=$REAL_CXX', 'CXX="ccache $REAL_CXX"', 'CC="ccache $REAL_CC"', 'mk_add_options PROFILE_GEN_SCRIPT=@TOPSRCDIR@/build/profile_pageloader.pl', 'ac_add_options --enable-codesighs', 'mk_add_options MOZ_MAKE_FLAGS="-j4"', 'ac_add_options --enable-signmar', 'ac_add_options --enable-js-diagnostics', 'ac_add_options --with-ccache=/usr/bin/ccache', 'export MOZILLA_OFFICIAL=1', 'export MOZ_TELEMETRY_REPORTING=1', "mk_add_options PROFILE_GEN_SCRIPT='$(PYTHON) @MOZ_OBJDIR@/_profile/pgo/profileserver.py 10'", 'STRIP_FLAGS="--strip-debug"']!
2012-09-04 12:12:43,045 : ERROR : found in browser/config/mozconfigs/linux32/nightly but not in browser/config/mozconfigs/linux32/release: ac_add_options --disable-profiling
2012-09-04 12:12:43,045 : ERROR : Error verifying mozconfigs