nightly mozconfigs in mozilla-aurora/beta should not have --disable-profiling

RESOLVED FIXED

Status

()

Firefox
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: catlee, Assigned: Ehsan)

Tracking

16 Branch
Points:
---

Firefox Tracking Flags

(firefox16 fixed, firefox17 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
As part of our pre-release tests, we compare the nightly and release mozconfigs for each platform under $product/config/mozconfigs. The check has been failing for beta builds because the nightly mozconfigs have --disable-profiling, and the release mozconfig doesn't have it. The check doesn't know which is the default, so it's safer to have both mozconfigs contain the same flag.

This probably affects aurora and central as well.
(Reporter)

Comment 1

5 years ago
You can use `sed /enable-profiling/d` to delete lines, e.g.:

sed -i /enable-profiling/d browser/config/mozconfigs/linux32/nightly
Summary: release mozconfigs in mozilla-beta should have --disable-profiling → nightly mozconfigs in mozilla-aurora/beta should not have --disable-profiling
Created attachment 658934 [details] [diff] [review]
Aurora patch

Not sure if this requires approval, but here it goes.
Attachment #658934 - Flags: review?(catlee)
Attachment #658934 - Flags: approval-mozilla-aurora?
Created attachment 658935 [details] [diff] [review]
Beta patch
Attachment #658935 - Flags: review?(catlee)
Attachment #658935 - Flags: approval-mozilla-beta?
Also updated the docs.

https://wiki.mozilla.org/Release_Management/Merge_Documentation#Disable_profiling
(Reporter)

Updated

5 years ago
Attachment #658934 - Flags: review?(catlee) → review+
(Reporter)

Updated

5 years ago
Attachment #658935 - Flags: review?(catlee) → review+
Comment 0 mentions this affects central as well. Is that just not a problem because "release" mozconfigs aren't used there?
(In reply to comment #5)
> Comment 0 mentions this affects central as well. Is that just not a problem
> because "release" mozconfigs aren't used there?

release mozconfigs don't have --enable-profiling in them.
Attachment #658934 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #658935 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-aurora/rev/750ff40b02a6
https://hg.mozilla.org/releases/mozilla-beta/rev/3cc8d1e6a31f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-firefox16: --- → fixed
status-firefox17: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.