The default bug view has changed. See this FAQ.

Save As Template should correctly manage multiple selections

RESOLVED FIXED in seamonkey2.20

Status

SeaMonkey
MailNews: Message Display
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Trunk
seamonkey2.20

SeaMonkey Tracking Flags

(seamonkey2.20 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
At the moment Save As Template cannot deal with multiple selections, it only saves the first one selected.
(Assignee)

Comment 1

4 years ago
Created attachment 728754 [details] [diff] [review]
Allow saving of multiple templates
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #728754 - Flags: review?(mnyromyr)

Comment 2

4 years ago
> -function SaveAsTemplate(uri)
> +function SaveAsTemplate(aUris)
Might want backward compatibility to support TB extensions since TB only takes one. e.g.

if (typeof aUris == "String")
  aUris = [a Uris];

Comment 3

4 years ago
Comment on attachment 728754 [details] [diff] [review]
Allow saving of multiple templates

>+  for (let i = 0; i < num; i++)
>   {
>+    var uri = aUris[i];

Despite the context, I'd prefer using "let" here.

Also, please consider Philip's suggestion, including a respective comment.

r/moa=me with that.

Sorry for the delay. :-(
Attachment #728754 - Flags: superreview+
Attachment #728754 - Flags: review?(mnyromyr)
Attachment #728754 - Flags: review+
(Assignee)

Comment 4

4 years ago
Created attachment 744833 [details] [diff] [review]
Allow saving of multiple templates with backwards compatibility [Checked in: Comment 5]
Attachment #728754 - Attachment is obsolete: true
Attachment #744833 - Flags: superreview+
Attachment #744833 - Flags: review+
(Assignee)

Comment 5

4 years ago
Comment on attachment 744833 [details] [diff] [review]
Allow saving of multiple templates with backwards compatibility [Checked in: Comment 5]

https://hg.mozilla.org/comm-central/rev/825c641f6e2a
Attachment #744833 - Attachment description: Allow saving of multiple templates with backwards compatibility → Allow saving of multiple templates with backwards compatibility [Checked in: Comment 5]
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-seamonkey2.20: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.20
You need to log in before you can comment on or make changes to this bug.