Closed
Bug 786316
Opened 12 years ago
Closed 11 years ago
Save As Template should correctly manage multiple selections
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(seamonkey2.20 fixed)
RESOLVED
FIXED
seamonkey2.20
| Tracking | Status | |
|---|---|---|
| seamonkey2.20 | --- | fixed |
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.95 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
superreview+
|
Details | Diff | Splinter Review |
At the moment Save As Template cannot deal with multiple selections, it only saves the first one selected.
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #728754 -
Flags: review?(mnyromyr)
|
||
Comment 2•11 years ago
|
||
> -function SaveAsTemplate(uri)
> +function SaveAsTemplate(aUris)
Might want backward compatibility to support TB extensions since TB only takes one. e.g.
if (typeof aUris == "String")
aUris = [a Uris];
|
||
Comment 3•11 years ago
|
||
Comment on attachment 728754 [details] [diff] [review] Allow saving of multiple templates >+ for (let i = 0; i < num; i++) > { >+ var uri = aUris[i]; Despite the context, I'd prefer using "let" here. Also, please consider Philip's suggestion, including a respective comment. r/moa=me with that. Sorry for the delay. :-(
Attachment #728754 -
Flags: superreview+
Attachment #728754 -
Flags: review?(mnyromyr)
Attachment #728754 -
Flags: review+
Attachment #728754 -
Attachment is obsolete: true
Attachment #744833 -
Flags: superreview+
Attachment #744833 -
Flags: review+
Comment on attachment 744833 [details] [diff] [review] Allow saving of multiple templates with backwards compatibility [Checked in: Comment 5] https://hg.mozilla.org/comm-central/rev/825c641f6e2a
Attachment #744833 -
Attachment description: Allow saving of multiple templates with backwards compatibility → Allow saving of multiple templates with backwards compatibility [Checked in: Comment 5]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-seamonkey2.20:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.20
You need to log in
before you can comment on or make changes to this bug.
Description
•