Save As Template should correctly manage multiple selections

RESOLVED FIXED in seamonkey2.20

Status

defect
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Tracking

Trunk
seamonkey2.20
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.20 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

7 years ago
At the moment Save As Template cannot deal with multiple selections, it only saves the first one selected.
Assignee

Comment 1

6 years ago
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #728754 - Flags: review?(mnyromyr)

Comment 2

6 years ago
> -function SaveAsTemplate(uri)
> +function SaveAsTemplate(aUris)
Might want backward compatibility to support TB extensions since TB only takes one. e.g.

if (typeof aUris == "String")
  aUris = [a Uris];
Comment on attachment 728754 [details] [diff] [review]
Allow saving of multiple templates

>+  for (let i = 0; i < num; i++)
>   {
>+    var uri = aUris[i];

Despite the context, I'd prefer using "let" here.

Also, please consider Philip's suggestion, including a respective comment.

r/moa=me with that.

Sorry for the delay. :-(
Attachment #728754 - Flags: superreview+
Attachment #728754 - Flags: review?(mnyromyr)
Attachment #728754 - Flags: review+
Assignee

Comment 4

6 years ago
Attachment #728754 - Attachment is obsolete: true
Attachment #744833 - Flags: superreview+
Attachment #744833 - Flags: review+
Assignee

Comment 5

6 years ago
Comment on attachment 744833 [details] [diff] [review]
Allow saving of multiple templates with backwards compatibility [Checked in: Comment 5]

https://hg.mozilla.org/comm-central/rev/825c641f6e2a
Attachment #744833 - Attachment description: Allow saving of multiple templates with backwards compatibility → Allow saving of multiple templates with backwards compatibility [Checked in: Comment 5]
Assignee

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.20
You need to log in before you can comment on or make changes to this bug.