786326 - first popup of flyout panel doesn't show arrow

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

images showing this are in bug 785952, and per comment #7 we should set the side attribute to fix this.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: arrow patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Why does this only affect the first popup?

Comment 3

[Shane Caraveo (:mixedpuppy)]

Neil, (In reply to :Gavin Sharp (use [e-mail] for email) from comment #2)
> Why does this only affect the first popup?

TBH I'm not certain, but I think it has to do with panel.boxObject.show setting up display prior to css being set during popupshowing.  I haven't traced everything through the boxobject class, there's a lot to digest.  Maybe Neil can give a more informed answer?

Comment 4

[Neil Deakin]

The side attribute can be computed dynamically based on where the panel is opened, the position of which can be specified differently for each call to openPopup. However, the computations only work when the horizontal or vertical arrangement is known beforehand (defaulting to vertical like the bookmarks panel). This issue can also occur if you open a popup to the side and then open it vertically. Since changing the orientation isn't a normal operation (indeed, we haven't seen usage of side arrow panels yet), the arrow panels don't currently handle it.

Comment 5

[Shane Caraveo (:mixedpuppy)]

https://tbpl.mozilla.org/?tree=Try&rev=944991a1b7ab

Comment 6

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 656062 [details] [diff] [review]
arrow patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: initial open of social side panel fails to show correctly
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6e9c83b3ba5b
https://hg.mozilla.org/releases/mozilla-aurora/rev/dce109c23ef3

Comment 8

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/mozilla-central/rev/6e9c83b3ba5b

Comment 9

[Manuela Muntean [Away]]

This issue is fixed on Firefox 17 Release Candidate, User Agent:Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Firefox/17.0, Build ID: 20121116115405. (the arrow is visible)

Marking this as verified.

Comment 10

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old