Closed Bug 786326 Opened 8 years ago Closed 8 years ago

first popup of flyout panel doesn't show arrow

Categories

(Firefox Graveyard :: SocialAPI, defect)

x86
macOS
defect
Not set

Tracking

(firefox17 verified)

RESOLVED FIXED
Firefox 18
Tracking Status
firefox17 --- verified

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Details

(Whiteboard: [Fx17])

Attachments

(1 file)

images showing this are in bug 785952, and per comment #7 we should set the side attribute to fix this.
Attached patch arrow patchSplinter Review
Attachment #656062 - Flags: review?(gavin.sharp)
Why does this only affect the first popup?
Neil, (In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #2)
> Why does this only affect the first popup?

TBH I'm not certain, but I think it has to do with panel.boxObject.show setting up display prior to css being set during popupshowing.  I haven't traced everything through the boxobject class, there's a lot to digest.  Maybe Neil can give a more informed answer?
The side attribute can be computed dynamically based on where the panel is opened, the position of which can be specified differently for each call to openPopup. However, the computations only work when the horizontal or vertical arrangement is known beforehand (defaulting to vertical like the bookmarks panel). This issue can also occur if you open a popup to the side and then open it vertically. Since changing the orientation isn't a normal operation (indeed, we haven't seen usage of side arrow panels yet), the arrow panels don't currently handle it.
Attachment #656062 - Flags: review?(gavin.sharp) → review+
Comment on attachment 656062 [details] [diff] [review]
arrow patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: initial open of social side panel fails to show correctly
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch: none
Attachment #656062 - Flags: approval-mozilla-aurora?
Attachment #656062 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6e9c83b3ba5b
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Keywords: verifyme
QA Contact: anthony.s.hughes
This issue is fixed on Firefox 17 Release Candidate, User Agent:Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Firefox/17.0, Build ID: 20121116115405. (the arrow is visible)

Marking this as verified.
mass remove verifyme requests greater than 4 months old
Keywords: verifyme
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.