Closed Bug 786372 Opened 8 years ago Closed 8 years ago

eliminate warnings about C++ comments in C header files in media/

Categories

(Core :: Audio/Video, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: froydnj, Assigned: froydnj)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

libvpx compilation spews errors like:

In file included from /home/froydnj/src/mozilla-central-official/media/libvpx/vp8/common/alloccommon.c:13:0:
/home/froydnj/src/mozilla-central-official/media/libvpx/vp8/common/blockd.h:177:5: warning: C++ style comments are not allowed in ISO C90 [enabled by default]
/home/froydnj/src/mozilla-central-official/media/libvpx/vp8/common/blockd.h:177:5: warning: (this will be reported only once per input file) [enabled by default]

This is due to our use of -pedantic.  Upstream doesn't compile with -pedantic, so why should we?
Attached patch patchSplinter Review
This patch removes -pedantic from the compile flags.  It's similar to the approach taken by other parts of the tree, e.g. Cairo.  libvpx compiles nearly warning-free with this patch (1 warning about braces around an if remains).
Attachment #656112 - Flags: review?(tterribe)
Attachment #656112 - Flags: review?(tterribe) → review+
We should probably do this for libtheora, too.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a151960d655c

(In reply to Timothy B. Terriberry (:derf) from comment #2)
> We should probably do this for libtheora, too.

I'll do a patch for that, too (my normal build doesn't include libtheora).
Assignee: nobody → nfroyd
Summary: eliminate warnings about C++ comments in C header files → eliminate warnings about C++ comments in C header files in media/
Whiteboard: [leave open]
And the libtheora counterpart.
Attachment #656154 - Flags: review?(tterribe)
Attachment #656154 - Flags: review?(tterribe) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/089fd92d1553
Status: NEW → ASSIGNED
Whiteboard: [leave open]
https://hg.mozilla.org/mozilla-central/rev/a151960d655c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Blocks: 787040
You need to log in before you can comment on or make changes to this bug.