786372 - eliminate warnings about C++ comments in C header files in media/

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Nathan Froyd [:froydnj]]

libvpx compilation spews errors like:

In file included from /home/froydnj/src/mozilla-central-official/media/libvpx/vp8/common/alloccommon.c:13:0:
/home/froydnj/src/mozilla-central-official/media/libvpx/vp8/common/blockd.h:177:5: warning: C++ style comments are not allowed in ISO C90 [enabled by default]
/home/froydnj/src/mozilla-central-official/media/libvpx/vp8/common/blockd.h:177:5: warning: (this will be reported only once per input file) [enabled by default]

This is due to our use of -pedantic.  Upstream doesn't compile with -pedantic, so why should we?

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: patch

This patch removes -pedantic from the compile flags.  It's similar to the approach taken by other parts of the tree, e.g. Cairo.  libvpx compiles nearly warning-free with this patch (1 warning about braces around an if remains).

Comment 2

[Timothy B. Terriberry (:derf)]

We should probably do this for libtheora, too.

Comment 3

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a151960d655c

(In reply to Timothy B. Terriberry (:derf) from comment #2)
> We should probably do this for libtheora, too.

I'll do a patch for that, too (my normal build doesn't include libtheora).

Comment 4

[Nathan Froyd [:froydnj]]

Attachment: eliminate warnings in libtheora

And the libtheora counterpart.

Comment 5

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/089fd92d1553

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a151960d655c

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/089fd92d1553