eliminate warnings about C++ comments in C header files in media/

RESOLVED FIXED in mozilla18

Status

()

Core
Audio/Video
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

(Blocks: 1 bug)

unspecified
mozilla18
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
libvpx compilation spews errors like:

In file included from /home/froydnj/src/mozilla-central-official/media/libvpx/vp8/common/alloccommon.c:13:0:
/home/froydnj/src/mozilla-central-official/media/libvpx/vp8/common/blockd.h:177:5: warning: C++ style comments are not allowed in ISO C90 [enabled by default]
/home/froydnj/src/mozilla-central-official/media/libvpx/vp8/common/blockd.h:177:5: warning: (this will be reported only once per input file) [enabled by default]

This is due to our use of -pedantic.  Upstream doesn't compile with -pedantic, so why should we?
(Assignee)

Comment 1

6 years ago
Created attachment 656112 [details] [diff] [review]
patch

This patch removes -pedantic from the compile flags.  It's similar to the approach taken by other parts of the tree, e.g. Cairo.  libvpx compiles nearly warning-free with this patch (1 warning about braces around an if remains).
Attachment #656112 - Flags: review?(tterribe)
Attachment #656112 - Flags: review?(tterribe) → review+
We should probably do this for libtheora, too.
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a151960d655c

(In reply to Timothy B. Terriberry (:derf) from comment #2)
> We should probably do this for libtheora, too.

I'll do a patch for that, too (my normal build doesn't include libtheora).
Assignee: nobody → nfroyd
Summary: eliminate warnings about C++ comments in C header files → eliminate warnings about C++ comments in C header files in media/
Whiteboard: [leave open]
(Assignee)

Comment 4

6 years ago
Created attachment 656154 [details] [diff] [review]
eliminate warnings in libtheora

And the libtheora counterpart.
Attachment #656154 - Flags: review?(tterribe)
Attachment #656154 - Flags: review?(tterribe) → review+
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/089fd92d1553
Status: NEW → ASSIGNED
Whiteboard: [leave open]
https://hg.mozilla.org/mozilla-central/rev/a151960d655c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Blocks: 787040
You need to log in before you can comment on or make changes to this bug.