787040 - eliminate warnings under ipc/

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Landry Breuil (:gaston)]

+++ This bug was initially created as a clone of Bug #786372 +++

ipc compilation with gcc 4.6 (since ipc uses -pedantic) spews warnings like:

ipc/chromium/src/base/ref_counted.h:31:28: warning: extra ';' [-pedantic]
ipc/chromium/src/chrome/common/file_descriptor_set_posix.h:33:36: warning: comma at end of enumerator list [-pedantic]

let's fix them for nice build logs.

Comment 1

[Landry Breuil (:gaston)]

All uses of HANDLE_EINTR also yields :

ipc/chromium/src/base/process_util_posix.cc:335:19: warning: ISO C++ forbids braced-groups within expressions [-pedantic]
ipc/chromium/src/base/process_util_posix.cc:355:15: warning: ISO C++ forbids braced-groups within expressions [-pedantic]
ipc/chromium/src/base/process_util_posix.cc:370:24: warning: ISO C++ forbids braced-groups within expressions [-pedantic]
ipc/chromium/src/base/process_util_posix.cc:511:15: warning: ISO C++ forbids braced-groups within expressions [-pedantic]

Comment 2

[Landry Breuil (:gaston)]

As for the HANDLE_EINTR, there are two cases :
if i remove the braces around its definition, when 'return HANDLE_EINTR()' is used it now barfs with 

ipc/chromium/src/base/file_descriptor_shuffle.cc: In member function 'virtual bool base::FileDescriptorTableInjection::Duplicate(int*, int)':
ipc/chromium/src/base/file_descriptor_shuffle.cc:82:13: error: expected primary-expression before 'typeof'
ipc/chromium/src/base/file_descriptor_shuffle.cc:82:13: error: expected '}' before 'typeof'
ipc/chromium/src/base/file_descriptor_shuffle.cc:82:13: error: cannot convert '<brace-enclosed initializer list>' to 'int' in assignment
ipc/chromium/src/base/file_descriptor_shuffle.cc:82:13: error: expected ';' before 'typeof'
ipc/chromium/src/base/file_descriptor_shuffle.cc:82:13: error: '__eintr_result__' was not declared in this scope
ipc/chromium/src/base/file_descriptor_shuffle.cc:82:13: error: '__eintr_result__' was not declared in this scope
ipc/chromium/src/base/file_descriptor_shuffle.cc:82:13: error: no return statement in function returning non-void [-Werror=return-type]

readding braces around the macro 'fixes' it but it's ugly. (ie return (HANDLE_EINTR(xxx)); )

The other option would be to 'fix' the other callers where the return value is used (ie foo = HANDLE_EINTR(xxx); ) but i dont know how.

Comment 3

[Landry Breuil (:gaston)]

I give up on HANDLE_EINTR, even if i move braces around some of the users still yield 'warning: ISO C++ forbids braced-groups within expressions'

Comment 4

[Landry Breuil (:gaston)]

Attachment: shut up some warnings

Not all warnings are fixed, but at least there's not a vomit at each file built under ipc/.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 656940 [details] [diff] [review]
shut up some warnings

Review of attachment 656940 [details] [diff] [review]:
-----------------------------------------------------------------

Can you fix the other cases of http://mxr.mozilla.org/mozilla-central/ident?i=DFAKE_MUTEX&filter= too?

Comment 6

[Landry Breuil (:gaston)]

Attachment: silence some warnings incl in unittests

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 656976 [details] [diff] [review]
silence some warnings incl in unittests

Review of attachment 656976 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 8

[Landry Breuil (:gaston)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a42606a108e6

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a42606a108e6