786593 - Moving a tab to a different window leaves other tabs shifted in the source window

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Ed Morley [:emorley]]

http://hg.mozilla.org/mozilla-central/rev/8af2ff9c6018
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0

1) Start Nightly
2) Ctrl+N for a new window
3) Open several (3+) new tabs in each window
4) Drag the rightmost (though this probably happens for any of them) tab from one window to the other

Expected:
* Tab detaches & is dropped in the new window at the location of the cursor.
* Gap in tab bar on old window is filled by the other tabs moving into the space
* Tabs can be opened/closed/dragged/switched between on both windows without the wrong tab being operated on

Actual:
* Tab doesn't always drop at the correct location on the new window's tab bar
* The old window's tab bar is left with a gap
* Subsequent tab operations (switching, closing etc) occur on the wrong tab

Comment 1

[Ed Morley [:emorley]]

(In reply to Ed Morley [:edmorley] from comment #0)
> * Subsequent tab operations (switching, closing etc) occur on the wrong tab

Also: middle mouse click (to close) some of the tabs on either window - you instead sometimes get a new tab opened (as though you had middle clicked on an empty space on the tab bar).

Comment 2

[Dão Gottwald [:dao]]

(In reply to Ed Morley [:edmorley] from comment #0)
> * Tab doesn't always drop at the correct location on the new window's tab bar

I can't reproduce this. Please file a separate bug if you have STR.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

Comment 5

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b132293a4701

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b132293a4701

Comment 7

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/be605a6e4ade

Comment 8

[Simona Badau, Desktop QA]

Verified as fixed on Firefox 17 beta 1 - when moving a tab to a different window, there are no gaps left in the other window, the tab can be dropped in the wanted location and the tab operations can be properly done.

Verified on Windows 7, Ubuntu 12.04 and Mac OS X 10.7:
Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/17.0 Firefox/17.0
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Firefox/17.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Firefox/17.0

Comment 9

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old