786897 - Command line option -private crashes, if privacy mode is enabled in preferences

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Matt Tagg]

How to reproduce.

Step 1. Create a blank profile -no-remote -profile /tmp/temp-profile
Step 2. Turn on "Always use private mode" (http://i.imgur.com/4UT7N.png)
Step 3. Quit
Step 4. Run with -private command line option

Crash 

---
(gdb)  run
Starting program: /Applications/FirefoxAurora.app/Contents/MacOS/firefox-bin -no-remote -profile /tmp/temp-profile -private
Reading symbols for shared libraries . done

Program exited with code 06.

Comment 1

[Scoobidiver (away)]

I confirm on Windows that 15.0, 16.0a2, or 18.0a1 don't start with the -private option if the profile is already in permanent browsing mode.

Comment 2

[Loic]

It's a regression since Firefox 4 (Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.2a1pre) Gecko/20110330 Firefox/4.2a1pre).

Mozregression range

m-c
good=2011-03-29
bad=2011-03-30
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=79487686ac29&tochange=2f45c30741c5

Suspected bug:
Ehsan Akhgari — Bug 631973 - Opening Firefox in permanent private browsing mode opens an additional window with the home page; r=gavin

Comment 3

[Josh Matthews [:jdm]]

CCing some people who might be interested in looking into this crash.

Comment 4

[Loic]

When I tested the regression on Win 7, I met no crash, Firefox just refused to start.

Comment 5

[Luqman Aden [:Luqman]]

On Linux x64, I got "Program exited normally.". Tried again and get "WARNING: Last startup was detected as a crash.: file /scratch/laden/mozilla-central/toolkit/components/startup/nsAppStartup.cpp, line 1017"

Comment 6

[Josh Matthews [:jdm]]

It would be worth figuring out whether bug 631973 is responsible. Try the steps at http://stackoverflow.com/questions/10350661/backout-unwanted-changes-and-make-a-patch-out-of-them to create a patch that reverts the change from that bug, build and see the the problem is still present.

Comment 7

[Luqman Aden [:Luqman]]

Yep, it does seem like bug 631973 is indeed responsible.

Comment 8

[(no longer active)]

(In reply to Luqman Aden from comment #7)
> Yep, it does seem like bug 631973 is indeed responsible.

Thanks for the analysis!  Can you please try and see if you can fix this?  Thanks!

Comment 9

[Luqman Aden [:Luqman]]

Attachment: Bug 786897 - Command line option -private crashes, if privacy mode is enabled in preferences.

Testing locally with a clean profile seems to indicate that this fixes the issue.

Comment 10

[Josh Matthews [:jdm]]

Comment on attachment 657418 [details] [diff] [review]
Bug 786897 - Command line option -private crashes, if privacy mode is enabled in preferences.

What sayest thou, Ehsan?

Comment 11

[Luqman Aden [:Luqman]]

Attachment: Bug 786897 - Command line option -private crashes, if privacy mode is enabled in preferences.

Oops, the autostarted part is needed for the tests.

Comment 12

[Luqman Aden [:Luqman]]

https://tbpl.mozilla.org/?tree=Try&rev=1b22eeea67fa

Comment 13

[(no longer active)]

Comment on attachment 657493 [details] [diff] [review]
Bug 786897 - Command line option -private crashes, if privacy mode is enabled in preferences.

Review of attachment 657493 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  Please also add a comment saying that we don't need to go into PB mode a second time if we're in auto-started mode.

Please attach so that we can land this.  :-)

Comment 14

[Luqman Aden [:Luqman]]

Attachment: Bug 786897 - Command line option -private crashes, if privacy mode is enabled in preferences.

Comment 15

[Luqman Aden [:Luqman]]

Attachment: Command line option -private crashes, if privacy mode is enabled in preferences.

Comment 16

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f7e341a22ff

Comment 17

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7f7e341a22ff