786999 - Remove ellipsis from "Site Settings..." menu item string

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ioana Chiorean]

Attachment: Screenshot

Build ID: 17.0a2 (2012-08-29) Aurora Channel
Device: Galaxy Nexus 
OS: Android 4.0.4

Steps to reproduce:
1. Open Fennec 
2. Press long the URL bar

Expected result:
- Urlbar context menu should be consistent, following same rules for display

Actual result:
- The new added option Site settings presents 3 dots after it: Site Settings....

Note: 
- bug 781900 tracks the decision to move site preferences menu item to the urlbar context menu

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

The intention is to use "..." for any action the requires more user attention. In this case a dialog appears for the user to manage the site settings.

Adding Ian so UX can provide thoughts

Comment 2

[Ioana Chiorean]

If this is the intention to have ".." (2 not 3 dots)  we should take into account also share option for consistency. Share also implies an action the requires more user attention.

Comment 3

[Wesley Johnston (:wesj)]

We're using the unicode ellipsis character, so it is probably dependent on your system font? On all my devices it is three dots.

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/locales/en-US/android_strings.dtd#154

Comment 4

[Ioana Chiorean]

There are 3 dots, yes. I made a mistake in comment 2.

Comment 5

[:Margaret Leibovic]

I agree that this ellipsis is inconsistent. Even if it does follow the interaction pattern of "the user needs to do more", it's the only ellipsis we use in a menu item in the product. Also, there are actually other items that end up requiring more action, such as "Share", that don't have an ellipsis.

Are there any Android UX guidelines on this? I'd really like to get rid of it.

Comment 6

[Ian Barlow (:ibarlow)]

Attachment: menu example

I don't know of any Android guideline that frowns on ellipses, but we actually started using a little carat in our overflow menu to indicate there is another level to the interaction. 

For consistency's sake, it would make sense to use that here instead of the ellipsis.

Comment 7

[:Margaret Leibovic]

(In reply to Ian Barlow (:ibarlow) from comment #6)

> I don't know of any Android guideline that frowns on ellipses, but we
> actually started using a little carat in our overflow menu to indicate there
> is another level to the interaction. 

How important is this carat? I ask mainly because I'm lazy, but partially because I think that the user will understand that "Site Settings" is going to take them somewhere else. I think the ellipsis was initially introduced (and much more important) when this string used to be "Clear Site Settings...".

Comment 8

[Ian Barlow (:ibarlow)]

Another non-caraty approach might be to use a verb to make the "Site settings" item read the same way as everything else in the list. So something like

'Show site settings'
or
'Edit site settings'

Comment 9

[:Margaret Leibovic]

Attachment: patch

I think no caret is nice for staying consistent with all our other context menu items. I decided to go with "Edit Site Settings", since this item brings up a dialog that asks 

While I was messing around with these strings, I decided to update the dialog title to simply be "Site Settings". Right now we're reusing the same string for this dialog title and for the context menu item, and that doesn't really make sense.

Eventually it would be nice to replace this dialog with better UI, but I think these are some good improvements in the meantime.

Comment 10

[Ian Barlow (:ibarlow)]

(In reply to :Margaret Leibovic from comment #9)

> Eventually it would be nice to replace this dialog with better UI, but I
> think these are some good improvements in the meantime.

Agreed.

Comment 11

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9064e2ab1e2

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b9064e2ab1e2