781900 - Move site preferences menu item to the urlbar context menu

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

We can remove this item from our default menu and add it to the urlbar context menu (Later we could add it to the awesomescreen too? but don't want to distract from the easier fix here...).

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Adding Ian. This would be an easy win to remove a rarely used menuitem from the main menu.

Comment 2

[Ian Barlow (:ibarlow)]

Awesome idea. It might make sense to change the menu title to simply read "Site Settings", instead of "Clear Site Settings" as well -- you don't always open this item to clear everything out, sometimes you might just turn one thing on or off.

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch 1/2

This moves the menu item. Doing the strings in a separate patch so that we can uplift this easier.

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Strings Patch 2/2

This changes this string to "Site Settings…".

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 652873 [details] [diff] [review]
Patch 1/2

You added to GeckoApp.java because that's where the context menu handler is now. Should that be moved to BrowserApp in a new bug?

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 652875 [details] [diff] [review]
Strings Patch 2/2

I like how we didn't need to change any other files because the entity in strings.xml.in did not need to change.

Comment 7

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/31f1b05f1bd5
https://hg.mozilla.org/integration/mozilla-inbound/rev/04472ce8d6cd

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/31f1b05f1bd5
https://hg.mozilla.org/mozilla-central/rev/04472ce8d6cd

Comment 10

[Aaron Train [:aaronmt]]

Adrian, please update any test-cases.

Comment 11

[Ioana Chiorean]

Clear Site Preferences is now moved to URL bar as Site Settings... 
For clearing the inconsistencies in URL bar context menu is filled Bug 786999. 

Adrian will follow up when TC is updated.

Comment 12

[Ioana Chiorean]

^^ 
Build ID: 17.0a2 (2012-08-29) Aurora Channel
Device: Galaxy Nexus 
OS: Android 4.0.4

Comment 13

[Adrian Tamas (:AdrianT)]

Changed the test cases for Firefox 17 and up for both phones and tablets.

Changed tests:
https://moztrap.mozilla.org/manage/cases/_detail/5308/
https://moztrap.mozilla.org/manage/cases/_detail/5298/
https://moztrap.mozilla.org/manage/cases/_detail/5436/  - also updated the Custom Menu content with Apps and Reading list items