Closed Bug 787093 Opened 8 years ago Closed 8 years ago

"profile" link in share panel opens in the current tab

Categories

(Firefox Graveyard :: SocialAPI, defect)

17 Branch
defect
Not set

Tracking

(firefox17 verified)

VERIFIED FIXED
Firefox 18
Tracking Status
firefox17 --- verified

People

(Reporter: ianbicking, Assigned: mixedpuppy)

Details

(Whiteboard: [Fx17])

Attachments

(1 file)

When clicking on some links, like the self-profile link, the page opens in the current tab.  In other cases the links open in a new tab.  I'm guessing the social provider handles this (perhaps with target=_blank), but I think all links should be forced to open in new tabs, unless perhaps there is a tab already open with that exact URL (like a homepage), in which case selecting that tab would be excellent.
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [Fx17]
Version: 18 Branch → 17 Branch
(In reply to Ian Bicking (:ianb) from comment #0)
> but I think all links should be forced to open in new tabs, unless perhaps there is
> a tab already open with that exact URL (like a homepage), in which case
> selecting that tab would be excellent.

This is tricky to get right - some providers might have functionality that depends on link navigation not being redirected to work properly. For app-tabs, we use a heuristic (try to redirect untargeted links to "external sites" to other tabs), and we've extended that to social panels, but that obviously doesn't catch all cases. The simplest approach is to just have the providers target their links correctly, but it's not clear to me yet whether that's the right tradeoff.
Attached patch openintab.patchSplinter Review
From what I can see, only the profile link in the menu is opening in the current tab.  This is also the link that is part of chrome, rather than a link in content.  This patch fixes opening the profile (from the provider menu) in a new tab.  This is more consistent with how we are opening new tabs from content.
Attachment #657416 - Flags: review?(gavin.sharp)
Comment on attachment 657416 [details] [diff] [review]
openintab.patch

Oh! I guess I missed that part of comment 0 :) Makes sense!
Attachment #657416 - Flags: approval-mozilla-aurora+
Attachment #657416 - Flags: review?(gavin.sharp) → review+
Keywords: checkin-needed
Assignee: nobody → mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/7a86d43be76f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Summary: Some links from social dialogs open in the current tab → "profile" link in share panel opens in the current tab
Keywords: verifyme
QA Contact: anthony.s.hughes
Verified fixed with latest Firefox 17.0a2 and 18.0a1.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.