Closed Bug 787184 Opened 7 years ago Closed 7 years ago
Use generic install/copy rule in target
No description provided.
This is the minimum required for bug 755724. Others will follow.
https://tbpl.mozilla.org/?tree=Try&rev=2f16e19ccf16 The VPATH and .LIBPATTERN part comes from bug 243065, and was used to handle dependencies in the form -lfoo. We've stopped using these dependencies with bug 584474. They need to be removed, otherwise make tries to do unuseful things with the rules that install in $(DIST)/lib: config/rules.mk:832: Commands were specified for file `libmozglue.a.desc' at config/rules.mk:1561, config/rules.mk:832: but `libmozglue.a.desc' is now considered the same file as `../../dist/lib/libmozglue.a.desc'. config/rules.mk:832: Commands for `../../dist/lib/libmozglue.a.desc' will be ignored in favor of those for `libmozglue.a.desc'. make: Circular ../../dist/lib/libmozglue.a.desc <- ../../dist/lib/libmozglue.a.desc dependency dropped. Components are not treated because of the commands that need to be run after the files are installed. That needs ad-hoc targets, and that should be the object of another bug.
Attachment #658832 - Flags: review?(ted.mielczarek)
Attachment #656998 - Attachment is obsolete: true
https://tbpl.mozilla.org/?tree=Try&rev=3b3115774949 Try with tests, in case missing files would subtly trigger test failures.
Comment on attachment 658832 [details] [diff] [review] Use generic install/copy rule in target_libs.mk Review of attachment 658832 [details] [diff] [review]: ----------------------------------------------------------------- ::: config/makefiles/target_libs.mk @@ +49,3 @@ > ifdef SHARED_LIBRARY > ifdef IS_COMPONENT > $(INSTALL) $(IFLAGS2) $(SHARED_LIBRARY) $(FINAL_TARGET)/components Is there a reason this rule didn't get converted?
Attachment #658832 - Flags: review?(ted.mielczarek) → review+
(In reply to Ted Mielczarek [:ted] from comment #4) > Is there a reason this rule didn't get converted? See last paragraph in comment 2.
Thanks, missed that.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.