Closed
Bug 787184
Opened 13 years ago
Closed 13 years ago
Use generic install/copy rule in target_libs.mk
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla18
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
11.45 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•13 years ago
|
||
This is the minimum required for bug 755724. Others will follow.
Assignee | ||
Comment 2•13 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=2f16e19ccf16
The VPATH and .LIBPATTERN part comes from bug 243065, and was used to handle dependencies in the form -lfoo. We've stopped using these dependencies with bug 584474. They need to be removed, otherwise make tries to do unuseful things with the rules that install in $(DIST)/lib:
config/rules.mk:832: Commands were specified for file `libmozglue.a.desc' at config/rules.mk:1561,
config/rules.mk:832: but `libmozglue.a.desc' is now considered the same file as `../../dist/lib/libmozglue.a.desc'.
config/rules.mk:832: Commands for `../../dist/lib/libmozglue.a.desc' will be ignored in favor of those for `libmozglue.a.desc'.
make[1]: Circular ../../dist/lib/libmozglue.a.desc <- ../../dist/lib/libmozglue.a.desc dependency dropped.
Components are not treated because of the commands that need to be run after the files are installed. That needs ad-hoc targets, and that should be the object of another bug.
Attachment #658832 -
Flags: review?(ted.mielczarek)
Assignee | ||
Updated•13 years ago
|
Attachment #656998 -
Attachment is obsolete: true
Assignee | ||
Comment 3•13 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=3b3115774949 Try with tests, in case missing files would subtly trigger test failures.
Comment 4•13 years ago
|
||
Comment on attachment 658832 [details] [diff] [review]
Use generic install/copy rule in target_libs.mk
Review of attachment 658832 [details] [diff] [review]:
-----------------------------------------------------------------
::: config/makefiles/target_libs.mk
@@ +49,3 @@
> ifdef SHARED_LIBRARY
> ifdef IS_COMPONENT
> $(INSTALL) $(IFLAGS2) $(SHARED_LIBRARY) $(FINAL_TARGET)/components
Is there a reason this rule didn't get converted?
Attachment #658832 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 5•13 years ago
|
||
(In reply to Ted Mielczarek [:ted] from comment #4)
> Is there a reason this rule didn't get converted?
See last paragraph in comment 2.
Comment 6•13 years ago
|
||
Thanks, missed that.
Assignee | ||
Comment 7•13 years ago
|
||
Comment 8•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•