787184 - Use generic install/copy rule in target_libs.mk

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Start with PROGRAM only

This is the minimum required for bug 755724. Others will follow.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Use generic install/copy rule in target_libs.mk

https://tbpl.mozilla.org/?tree=Try&rev=2f16e19ccf16

The VPATH and .LIBPATTERN part comes from bug 243065, and was used to handle dependencies in the form -lfoo. We've stopped using these dependencies with bug 584474. They need to be removed, otherwise make tries to do unuseful things with the rules that install in $(DIST)/lib:

config/rules.mk:832: Commands were specified for file `libmozglue.a.desc' at config/rules.mk:1561,
config/rules.mk:832: but `libmozglue.a.desc' is now considered the same file as `../../dist/lib/libmozglue.a.desc'.
config/rules.mk:832: Commands for `../../dist/lib/libmozglue.a.desc' will be ignored in favor of those for `libmozglue.a.desc'.
make[1]: Circular ../../dist/lib/libmozglue.a.desc <- ../../dist/lib/libmozglue.a.desc dependency dropped.

Components are not treated because of the commands that need to be run after the files are installed. That needs ad-hoc targets, and that should be the object of another bug.

Comment 3

[Mike Hommey [:glandium]]

https://tbpl.mozilla.org/?tree=Try&rev=3b3115774949 Try with tests, in case missing files would subtly trigger test failures.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 658832 [details] [diff] [review]
Use generic install/copy rule in target_libs.mk

Review of attachment 658832 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/makefiles/target_libs.mk
@@ +49,3 @@
>  ifdef SHARED_LIBRARY
>  ifdef IS_COMPONENT
>  	$(INSTALL) $(IFLAGS2) $(SHARED_LIBRARY) $(FINAL_TARGET)/components

Is there a reason this rule didn't get converted?

Comment 5

[Mike Hommey [:glandium]]

(In reply to Ted Mielczarek [:ted] from comment #4)
> Is there a reason this rule didn't get converted?

See last paragraph in comment 2.

Comment 6

[(not currently active) Ted Mielczarek]

Thanks, missed that.

Comment 7

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0fab33837886

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0fab33837886