Port |Bug 628695 - Make invalid form popup offset aware of the zoom level| to SeaMonkey

RESOLVED FIXED in seamonkey2.15

Status

SeaMonkey
General
--
trivial
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

Trunk
seamonkey2.15

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Bug 626834 ported |Bug 624151 - Better positioning for the invalid form popup| to SeaMonkey. We should also port the dependencies.
(Assignee)

Comment 1

6 years ago
Created attachment 657310 [details] [diff] [review]
Patch v1.0 adjust to zoom level.

Tested using attachment 474241 [details] from Bug 561636.

>-    var offset = style.direction == 'rtl' ? parseInt(style.paddingRight) + 
(Trailing whitespace removed)

>+    offset = Math.round(offset * scale);
I remember vaguely somewhere that Gecko does sub-pixel positioning for layouts so perhaps Math.round() might not be necessary?
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #657310 - Flags: review?(neil)

Comment 2

6 years ago
Comment on attachment 657310 [details] [diff] [review]
Patch v1.0 adjust to zoom level.

I think the rounding is because the openPopup call takes integers.
Attachment #657310 - Flags: review?(neil) → review+
(Assignee)

Comment 3

6 years ago
Pushed comm-central changeset 81d1dff456f1
http://hg.mozilla.org/comm-central/rev/81d1dff456f1
Severity: normal → trivial
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.15
You need to log in before you can comment on or make changes to this bug.