787392 - Add Action/Toggle Button type

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Matteo Ferretti [:zer0] [:matteo]]

As the UX mockups shows:

http://people.mozilla.com/~shorlander/files/addons-in-toolbar-i01/addons-in-toolbar.html

Some widgets doesn't need a UI, but just a button "on/off". We need to provide to the developers a easy way to create those widgets, without doing that manually.

Comment 1

[Matteo Ferretti [:zer0] [:matteo]]

James Hall suggested for activated icons – he mentioned the AdBlock+, so I believe it's the Toggle's widget type – to have to displays them in a different state than pressed. See: https://bugzilla.mozilla.org/show_bug.cgi?id=695913#c18

I think it's a great idea use a different state for Toggle's Widgets than the pressed ones, because the Toolbar Widgets (see bug 787390) have that state as well, so could be not clear enough for the user.

Ben Bucksch also agreed and suggested a strike-through icon overlay for disabled ones.

Although I think would be nice have a strike-through icon overlay, I can see three major problem with that: icons that maybe have already a "strike-through" could be misunderstood (e.g. NoScript); and having multiple disabled icons with strike-through could make them more difficult do recognize because the overlay. In addition, if we allowed also for Toggle's widget to have multiple sizes (see https://bugzilla.mozilla.org/show_bug.cgi?id=645506#c20) we should apply different strike-through graphics as well, and makes them less standard to recognize.

I personally think that have an approach that doesn't cover the original icon suits better. Take as example the "active" light spot on Mac OS X, when an application is running; or the grayed out approach suggested by James.

Comment 2

[Matteo Ferretti [:zer0] [:matteo]]

Here the JEP:

https://github.com/mozilla/addon-sdk/wiki/JEP-Navbar-Buttons

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1038/files

Pointer to Github pull-request

Comment 4

[[github robot]]

Commits pushed to australis at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/4df58ba2c3a149ba01033d89a226c47cc44fba24
Bug 787392 - Add Action/Toggle Button type

- Added Button UI component
- Added "State" mechanism
- Implemented CustomizableUI from Australis
- Added Unit Test

https://github.com/mozilla/addon-sdk/commit/c4c2d037bdeec8deb9793fa80aee6e5e16ad950a
Merge pull request #1038 from ZER0/ui-button

Bug 787392 - Add Action/Toggle Button type r=@erikvold

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/4df58ba2c3a149ba01033d89a226c47cc44fba24
Bug 787392 - Add Action/Toggle Button type

https://github.com/mozilla/addon-sdk/commit/c4c2d037bdeec8deb9793fa80aee6e5e16ad950a
Merge pull request #1038 from ZER0/ui-button

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm going through the list of open bugs that github robot has commented in. Is this bug fixed, Matteo?

Comment 7

[Matteo Ferretti [:zer0] [:matteo]]

It's hard to answer. It's definitely in master now, but it works only on Australis build. Plus, there are some changes Irakli want to do before Australis, so I would leave it open.

Comment 8

[Matteo Ferretti [:zer0] [:matteo]]

Definitely fixed.