984013 - [Australis] checked toggle-button from addon sdk looks weird in tabbar

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect, P2)

Description

[[:philipp]]

Attachment: checked toggle-button.png

the background of a toggle-button in a checked state (created with the new functionality in the addon sdk as described at https://blog.mozilla.org/addons/2014/03/13/new-add-on-sdk-australis-ui-features-in-firefox-29/) that is placed on the tabbar, looks strange. 
it should probably look more like the download button in a pressed state.

Comment 1

[[:philipp]]

Attachment: pressed download button.png

Comment 2

[:Gijs (he/him)]

Matteo, can you help fix this?

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

Sure thing! But it's nothing strictly related to Add-on SDK, this would be the result of any regular XUL <toolbarbutton type="checkbox"> if moved / added in the tabbar.
Maybe bug 981700 didn't take in account the situation where such buttons could be placed there?

Comment 4

[Matteo Ferretti [:zer0] [:matteo]]

I don't think this should be considered an Add-on SDK bug, due the fact that is related to how Australis styles any <toolbarbutton type="checkbox"> added to the tabbar on Windows – on OS X, it seems consistent.

Comment 5

[:Gijs (he/him)]

(In reply to Matteo Ferretti [:matteo] [:zer0] from comment #4)
> I don't think this should be considered an Add-on SDK bug, due the fact that
> is related to how Australis styles any <toolbarbutton type="checkbox"> added
> to the tabbar on Windows – on OS X, it seems consistent.

Sure, but it's low prio for Australis in general, I think, because we don't ship these buttons. If you have time to work on it, that would be helpful, as we have our hands full with higher-prio bugs.

Comment 6

[Matteo Ferretti [:zer0] [:matteo]]

(In reply to :Gijs Kruitbosch (no internet 29 Mar - 6 Apr) from comment #5)

> Sure, but it's low prio for Australis in general, I think, because we don't
> ship these buttons. If you have time to work on it, that would be helpful,
> as we have our hands full with higher-prio bugs.

I'm afraid I also have other priority atm – plus, I still have to setup a Windows machine.
I will needinfo'ed me as reminder anyway, in case I was able to find a spot to work on it; but feel free to take it if you will be able to do some work before me.

Comment 7

[Matteo Ferretti [:zer0] [:matteo]]

Removing all needinfo flag from old SDK bugs, since I'm working on different projects and SDK is generally not a priority, now that we're focusing on WebExtension.