Closed
Bug 787920
Opened 14 years ago
Closed 14 years ago
Tests in dom/ipc/tests fail when the crash reporter is disabled
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: decoder, Unassigned)
Details
(Keywords: sec-want, Whiteboard: [asan-test-failure])
Just like in bug 779111, dom/ipc/tests/ has a single test and that one works only when the crashreporter is enabled. It is however not ifdef'ed.
This is turning ASan builds orange so I suggest to enable that test only when MOZ_CRASHREPORTER is defined. Patch following.
|
Reporter | |
Comment 1•14 years ago
|
||
Just noticed that the test does not actually fail but it outputs an ASan trace in the log because of the forced crash. Should I disable this test anyway?
|
||
Comment 2•14 years ago
|
||
That's up to you, but it's probably safe to say that none of our tests that invoke the crashreporter are testing the right thing on ASan builds, since ASan is handling the crashes differently anyway.
|
|
Reporter | |
Updated•14 years ago
|
No longer blocks: 438871
Whiteboard: [asan-test-failure][orange] → [asan-test-failure]
|
|
Reporter | |
Comment 3•14 years ago
|
||
Closing as WFM since the test is actually green. I'll reopen this if it turns out there is an actual problem with the trace in the log.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•