787971 - Fix warnings about function pointers in gtk2 webapprt

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Marco Castelluccio [:marco]]

Can you do the same for nsAlertsIconListener?

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 657879 [details] [diff] [review]
Patch v1

Review of attachment 657879 [details] [diff] [review]:
-----------------------------------------------------------------

::: webapprt/gtk2/webapprt.cpp
@@ +273,5 @@
>       * Passing the fourth argument as NULL is binary compatible.
>       */
> +    typedef void  (*notify_init_t)(const char*);
> +    typedef void* (*notify_notification_new_t)(const char*, const char*, const char*, const char*);
> +    typedef void  (*notify_notification_show_t)(void*, void*);

Since you're touching the second argument, you might as well make it a void ** (since it's a GError **).

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/73910fb9acdb