Closed Bug 787971 Opened 8 years ago Closed 8 years ago

Fix warnings about function pointers in gtk2 webapprt

Categories

(Firefox Graveyard :: Webapp Runtime, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 18

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
No description provided.
Attachment #657879 - Flags: review?(mh+mozilla)
Can you do the same for nsAlertsIconListener?
Comment on attachment 657879 [details] [diff] [review]
Patch v1

Review of attachment 657879 [details] [diff] [review]:
-----------------------------------------------------------------

::: webapprt/gtk2/webapprt.cpp
@@ +273,5 @@
>       * Passing the fourth argument as NULL is binary compatible.
>       */
> +    typedef void  (*notify_init_t)(const char*);
> +    typedef void* (*notify_notification_new_t)(const char*, const char*, const char*, const char*);
> +    typedef void  (*notify_notification_show_t)(void*, void*);

Since you're touching the second argument, you might as well make it a void ** (since it's a GError **).
Attachment #657879 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/73910fb9acdb
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.