Fix warnings about function pointers in gtk2 webapprt

RESOLVED FIXED in Firefox 18

Status

Product:
Firefox Graveyard
Component:
Webapp Runtime
Type:
defect
Status:
RESOLVED FIXED
Opened:
7 years ago
Updated:
4 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks 1 bug)

Version:
Trunk
Target:
Firefox 18
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Patch v1
3.04 KB, patch
glandium
: review+
Details | Diff | Splinter Review
Posted patch Patch v1 — — Splinter Review 
No description provided.
Attachment #657879 - Flags: review?(mh+mozilla)
Can you do the same for nsAlertsIconListener?
Comment on attachment 657879 [details] [diff] [review]
Patch v1

Review of attachment 657879 [details] [diff] [review]:
-----------------------------------------------------------------

::: webapprt/gtk2/webapprt.cpp
@@ +273,5 @@
>       * Passing the fourth argument as NULL is binary compatible.
>       */
> +    typedef void  (*notify_init_t)(const char*);
> +    typedef void* (*notify_notification_new_t)(const char*, const char*, const char*, const char*);
> +    typedef void  (*notify_notification_show_t)(void*, void*);

Since you're touching the second argument, you might as well make it a void ** (since it's a GError **).
Attachment #657879 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/73910fb9acdb
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.