787984 - Add tests for imContentSink.jsm

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Florian Quèze [:florian]]

imContentSink.jsm is the file where we filter out unwanted content from received messages before displaying them, so we should really not let regressions slip into it.

Comment 1

[Florian Quèze [:florian]]

Attachment: WIP

Comment 2

[Florian Quèze [:florian]]

Attachment: Patch v2

Mike, I think you wrote way more unit tests than Patrick and me, so I'm wondering if you would have some interesting feedback to offer on this.

Note for the code review: The change to newRuleset is just some cleanup. The change to cleanupNode fixes https://bugzilla.instantbird.org/show_bug.cgi?id=962.

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 657938 [details] [diff] [review]
Patch v2

+  // Allow id only with numbers.
+  addGlobalAllowedAttribute("id", function(aId) /^[0-9]+$/.test(aId));
Not /^\d+$/?

Besides that it looks OK (and all the tests pass ;)). As far as I can tell this should be a pretty thorough test of the content sink.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 657938 [details] [diff] [review]
Patch v2

Review of attachment 657938 [details] [diff] [review]:
-----------------------------------------------------------------

Looks OK to me.

Comment 5

[Florian Quèze [:florian]]

https://hg.mozilla.org/comm-central/rev/e0f0c746579f

Comment 6

[aleth [:aleth]]

http://hg.instantbird.org/instantbird/rev/404468ca63b9