Closed Bug 788157 Opened 10 years ago Closed 10 years ago
Inconsistencies in 'Share'
Currently, one can opt to share a page through Reader Mode's toolbar but one nay opt share a page through the device system menu due to it being disabled. -- Nightly (09/04) Samsung Galaxy Nexus (Android 4.1.1)
This patch depends on ReaderModeUtils introduced in the patches for bug 778489.
Attachment #659320 - Flags: review?(mark.finkle) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Comment on attachment 659320 [details] [diff] [review] Enable sharing while on Reader Mode [Approval Request Comment] User impact if declined: Inconsistent behaviour on the Share menu item. It should be able available while on reader mode just like in any other page. Testing completed (on m-c, etc.): Landed on m-c, no issues found. Risk to taking this patch (and alternatives if risky): Very low, just handle the about:reader case when sharing. String or UUID changes made by this patch: None.
Verified fixed on mozilla-central (09/12) XTI: Can you update any related test-cases that deal with sharing an article from within reader-mode?
(In reply to Aaron Train [:aaronmt] from comment #6) > Verified fixed on mozilla-central (09/12) > > XTI: Can you update any related test-cases that deal with sharing an article > from within reader-mode? The test-case regarding Share option in Reader Mode was updated: https://moztrap.mozilla.org/manage/case/1267/
Pushed to aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/2396eda42b00 This patch depends on the patches from bug 778489 to land in beta.
Comment on attachment 659320 [details] [diff] [review] Enable sharing while on Reader Mode Since we've a-'d bug 778489, we'll wait to get this polish fixed in FF17.
Attachment #659320 - Flags: approval-mozilla-beta+ → approval-mozilla-beta-
Share option is available both in Firefox Menu and Reader Mode toolbar in Reader Mode on the latest Beta build. -- Firefox 17.0b6 (2012-11-13) Device: Samsung Galaxy S2 OS: Android 4.0.3
You need to log in before you can comment on or make changes to this bug.