788157 - Inconsistencies in 'Share'

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Reader View, defect, P2)

Description

[Aaron Train [:aaronmt]]

Currently, one can opt to share a page through Reader Mode's toolbar but one nay opt share a page through the device system menu due to it being disabled.

--
Nightly (09/04)
Samsung Galaxy Nexus (Android 4.1.1)

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Enable sharing while on Reader Mode

Comment 2

[Lucas Rocha (:lucasr)]

This patch depends on ReaderModeUtils introduced in the patches for bug 778489.

Comment 3

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/c11b2042ea31

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c11b2042ea31

Comment 5

[Lucas Rocha (:lucasr)]

Comment on attachment 659320 [details] [diff] [review]
Enable sharing while on Reader Mode

[Approval Request Comment]
User impact if declined: Inconsistent behaviour on the Share menu item. It should be able available while on reader mode just like in any other page.
Testing completed (on m-c, etc.): Landed on m-c, no issues found.
Risk to taking this patch (and alternatives if risky): Very low, just handle the about:reader case when sharing.
String or UUID changes made by this patch: None.

Comment 6

[Aaron Train [:aaronmt]]

Verified fixed on mozilla-central (09/12)

XTI: Can you update any related test-cases that deal with sharing an article from within reader-mode?

Comment 7

[Cristian Nicolae (:xti)]

(In reply to Aaron Train [:aaronmt] from comment #6)
> Verified fixed on mozilla-central (09/12)
> 
> XTI: Can you update any related test-cases that deal with sharing an article
> from within reader-mode?

The test-case regarding Share option in Reader Mode was updated: https://moztrap.mozilla.org/manage/case/1267/

Comment 8

[Lucas Rocha (:lucasr)]

Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/2396eda42b00

This patch depends on the patches from bug 778489 to land in beta.

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 659320 [details] [diff] [review]
Enable sharing while on Reader Mode

Since we've a-'d bug 778489, we'll wait to get this polish fixed in FF17.

Comment 10

[Cristian Nicolae (:xti)]

Share option is available both in Firefox Menu and Reader Mode toolbar in Reader Mode on the latest Beta build.

--
Firefox 17.0b6 (2012-11-13)
Device: Samsung Galaxy S2
OS: Android 4.0.3