Closed Bug 788157 Opened 11 years ago Closed 11 years ago

Inconsistencies in 'Share'

Categories

(Firefox for Android Graveyard :: Reader View, defect, P2)

Product:
Firefox for Android Graveyard
Component:
Reader View
Platform:
ARM
Android
Type:
defect

Tracking

(firefox16 affected, firefox17 verified, firefox18 verified, fennec+)

Status:
VERIFIED FIXED
Milestone:
Firefox 18
Tracking Flags:
Tracking Status
firefox16 --- affected
firefox17 --- verified
firefox18 --- verified
fennec + ---

People

(Reporter: aaronmt, Unassigned)

References

Details

Attachments

(1 file)

Enable sharing while on Reader Mode
2.32 KB, patch
mfinkle
: review+
akeybl
: approval-mozilla-aurora+
akeybl
: approval-mozilla-beta-
Details | Diff | Splinter Review 
Currently, one can opt to share a page through Reader Mode's toolbar but one nay opt share a page through the device system menu due to it being disabled.

--
Nightly (09/04)
Samsung Galaxy Nexus (Android 4.1.1)
See Also: → 785289
Priority: -- → P2
tracking-fennec: ? → +

        Attachment #659320 -
        Flags: review?(mark.finkle)

    
    

    
  
This patch depends on ReaderModeUtils introduced in the patches for bug 778489.

        Attachment #659320 -
        Flags: review?(mark.finkle) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/c11b2042ea31
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18

    
    

    
  
Comment on attachment 659320 [details] [diff] [review]
Enable sharing while on Reader Mode

[Approval Request Comment]
User impact if declined: Inconsistent behaviour on the Share menu item. It should be able available while on reader mode just like in any other page.
Testing completed (on m-c, etc.): Landed on m-c, no issues found.
Risk to taking this patch (and alternatives if risky): Very low, just handle the about:reader case when sharing.
String or UUID changes made by this patch: None.

        Attachment #659320 -
        Flags: approval-mozilla-beta?

        Attachment #659320 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Verified fixed on mozilla-central (09/12)

XTI: Can you update any related test-cases that deal with sharing an article from within reader-mode?
Status: RESOLVED → VERIFIED

          status-firefox18:
          --- → verified
Flags: in-moztrap?(nicolae.cristian)

    
  

        Attachment #659320 -
        Flags: approval-mozilla-beta?

        Attachment #659320 -
        Flags: approval-mozilla-beta+

        Attachment #659320 -
        Flags: approval-mozilla-aurora?

        Attachment #659320 -
        Flags: approval-mozilla-aurora+

    
    

    
  
(In reply to Aaron Train [:aaronmt] from comment #6)
> Verified fixed on mozilla-central (09/12)
> 
> XTI: Can you update any related test-cases that deal with sharing an article
> from within reader-mode?

The test-case regarding Share option in Reader Mode was updated: https://moztrap.mozilla.org/manage/case/1267/
Flags: in-moztrap?(nicolae.cristian) → in-moztrap+

    
    

    
  
Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/2396eda42b00

This patch depends on the patches from bug 778489 to land in beta.

    
    

    
  
Comment on attachment 659320 [details] [diff] [review]
Enable sharing while on Reader Mode

Since we've a-'d bug 778489, we'll wait to get this polish fixed in FF17.

        Attachment #659320 -
        Flags: approval-mozilla-beta+ → approval-mozilla-beta-

    
    

    
  
Share option is available both in Firefox Menu and Reader Mode toolbar in Reader Mode on the latest Beta build.

--
Firefox 17.0b6 (2012-11-13)
Device: Samsung Galaxy S2
OS: Android 4.0.3

          status-firefox17:
          fixed → verified

    
  
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.