788202 - When listing a frame tree, subdocument frames are not entered

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Chris Lord [:cwiiis]]

If you call nsFrame::List, the resultant tree will stop at any subdocument frames. This is a bit awkward if you're trying to debug a tree with subdocument frames.

Comment 1

[Chris Lord [:cwiiis]]

Attachment: Add nsSubDocumentFrame::List

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 658147 [details] [diff] [review]
Add nsSubDocumentFrame::List

This will actually break lots of current uses of List(), where you're trying to debug the layout of the document you're actually listing on.

In what cases do you actually _want_ this behavior?

Comment 3

[Chris Lord [:cwiiis]]

(In reply to Boris Zbarsky (:bz) from comment #2)
> Comment on attachment 658147 [details] [diff] [review]
> Add nsSubDocumentFrame::List
> 
> This will actually break lots of current uses of List(), where you're trying
> to debug the layout of the document you're actually listing on.
> 
> In what cases do you actually _want_ this behavior?

I was/am debugging invalidation issues and cross-referencing the frame-tree with invalidations, the display-list and the layer tree - One of the documents I'm looking at that has problems involves a sub-document and it was useful to see the entire frame-tree.

Perhaps adding a flag for this would be acceptable?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Ah, ok.  For graphics stuff, I agree it makes sense to descend into subframes.  For layout/style stuff, not so much.

So yeah, a flag would be great....

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 658147 [details] [diff] [review]
Add nsSubDocumentFrame::List

Per discussion.  Please add a flag?

Comment 6

[Chris Lord [:cwiiis]]

Attachment: Add optional subdocument traversal to nsIFrame::List

Add flag.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 661806 [details] [diff] [review]
Add optional subdocument traversal to nsIFrame::List

r=me

Comment 8

[Chris Lord [:cwiiis]]

Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/c82b3a413e0d

Comment 9

[Chris Lord [:cwiiis]]

Backed out due to build failures: https://hg.mozilla.org/integration/mozilla-inbound/rev/41e495ebeb89

Fixed and pushed to try first to verify: https://tbpl.mozilla.org/?tree=Try&rev=e3a5ed4c21a9

Comment 10

[Chris Lord [:cwiiis]]

Pushed to inbound again: https://hg.mozilla.org/integration/mozilla-inbound/rev/959cef323ed7

Comment 11

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/c82b3a413e0d
https://hg.mozilla.org/mozilla-central/rev/41e495ebeb89

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/959cef323ed7