Closed Bug 788202 Opened 7 years ago Closed 7 years ago

When listing a frame tree, subdocument frames are not entered

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: cwiiis, Assigned: cwiiis)

References

Details

Attachments

(1 file, 1 obsolete file)

If you call nsFrame::List, the resultant tree will stop at any subdocument frames. This is a bit awkward if you're trying to debug a tree with subdocument frames.
Attached patch Add nsSubDocumentFrame::List (obsolete) — Splinter Review
Attachment #658147 - Flags: review?(bzbarsky)
Comment on attachment 658147 [details] [diff] [review]
Add nsSubDocumentFrame::List

This will actually break lots of current uses of List(), where you're trying to debug the layout of the document you're actually listing on.

In what cases do you actually _want_ this behavior?
(In reply to Boris Zbarsky (:bz) from comment #2)
> Comment on attachment 658147 [details] [diff] [review]
> Add nsSubDocumentFrame::List
> 
> This will actually break lots of current uses of List(), where you're trying
> to debug the layout of the document you're actually listing on.
> 
> In what cases do you actually _want_ this behavior?

I was/am debugging invalidation issues and cross-referencing the frame-tree with invalidations, the display-list and the layer tree - One of the documents I'm looking at that has problems involves a sub-document and it was useful to see the entire frame-tree.

Perhaps adding a flag for this would be acceptable?
Ah, ok.  For graphics stuff, I agree it makes sense to descend into subframes.  For layout/style stuff, not so much.

So yeah, a flag would be great....
Comment on attachment 658147 [details] [diff] [review]
Add nsSubDocumentFrame::List

Per discussion.  Please add a flag?
Attachment #658147 - Flags: review?(bzbarsky) → review-
Add flag.
Attachment #658147 - Attachment is obsolete: true
Attachment #661806 - Flags: review?(bzbarsky)
Comment on attachment 661806 [details] [diff] [review]
Add optional subdocument traversal to nsIFrame::List

r=me
Attachment #661806 - Flags: review?(bzbarsky) → review+
Backed out due to build failures: https://hg.mozilla.org/integration/mozilla-inbound/rev/41e495ebeb89

Fixed and pushed to try first to verify: https://tbpl.mozilla.org/?tree=Try&rev=e3a5ed4c21a9
https://hg.mozilla.org/mozilla-central/rev/959cef323ed7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Depends on: 799196
You need to log in before you can comment on or make changes to this bug.